Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update HandlerMappingIntrospector Usage in CORS support #16501

Open
jzheaux opened this issue Jan 29, 2025 · 3 comments · May be fixed by #16657
Open

Update HandlerMappingIntrospector Usage in CORS support #16501

jzheaux opened this issue Jan 29, 2025 · 3 comments · May be fixed by #16657
Assignees
@jzheaux
Labels
in: config An issue in spring-security-config type: enhancement A general enhancement
Milestone
6.5.x

Comments

@jzheaux
Copy link
Contributor

jzheaux commented Jan 29, 2025 •
edited
Loading

The CorsConfigurationConfigurer should look up a PreFlightRequestHandler instead of a HandlerMappingIntrospector. It will still be registered under the same bean name in Framework 7, so that should remain as-is.

If a PreFlightRequestHandler is found by the given name, then safely cast it to CorsConfigurationSource and construct the CorsFilter as normal.
@jzheaux jzheaux mentioned this issue Jan 29, 2025
Open
1 task
@jzheaux jzheaux added in: config An issue in spring-security-config type: enhancement A general enhancement labels Feb 3, 2025
@jzheaux jzheaux self-assigned this Feb 4, 2025
@jzheaux
Copy link
Contributor Author

jzheaux commented Feb 4, 2025

@evgeniycheban, this ticket is yours. Once you comment, I'll be able to assign it to you officially.

@jzheaux jzheaux added this to the 6.5.x milestone Feb 4, 2025
@evgeniycheban
Copy link
Contributor

Hi, @jzheaux, please assign it to me.

evgeniycheban added a commit to evgeniycheban/spring-security that referenced this issue Feb 20, 2025
@evgeniycheban
Update HandlerMappingIntrospector Usage in CORS support
fb1ac0b 
Closes spring-projectsgh-16501
evgeniycheban added a commit to evgeniycheban/spring-security that referenced this issue Feb 20, 2025
@evgeniycheban
Update HandlerMappingIntrospector Usage in CORS support
c3d623b 
Closes spring-projectsgh-16501
@evgeniycheban evgeniycheban mentioned this issue Feb 20, 2025
Open
@evgeniycheban
Copy link
Contributor

Hi, @jzheaux I opened a PR to your fork.

evgeniycheban added a commit to evgeniycheban/spring-security that referenced this issue Feb 26, 2025
@evgeniycheban
Update HandlerMappingIntrospector Usage in CORS support
436345a 
Closes spring-projectsgh-16501
@evgeniycheban evgeniycheban linked a pull request Feb 26, 2025 that will close this issue
Open
evgeniycheban added a commit to evgeniycheban/spring-security that referenced this issue Feb 28, 2025
@evgeniycheban
Update HandlerMappingIntrospector Usage in CORS support
b591246 
Closes spring-projectsgh-16501
evgeniycheban added a commit to evgeniycheban/spring-security that referenced this issue Mar 1, 2025
@evgeniycheban
Update HandlerMappingIntrospector Usage in CORS support
f3aadd2 
Closes spring-projectsgh-16501
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jzheaux jzheaux

Labels
in: config An issue in spring-security-config type: enhancement A general enhancement
Projects
Spring Security Team
Status: No status
Milestone
6.5.x
Development

Successfully merging a pull request may close this issue.

Update HandlerMappingIntrospector Usage in CORS support evgeniycheban/spring-security
2 participants
@jzheaux @evgeniycheban