One Time Token login registers the default login page #16480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
Kehrlann
force-pushed
the
ott/enable-default-ui-ott-only
branch
3 times, most recently
from
9fc6606 to
3541139
Compare
Kehrlann
force-pushed
the
ott/enable-default-ui-ott-only
branch
from
3541139 to
3e87a99
Compare
Kehrlann
force-pushed
the
ott/enable-default-ui-ott-only
branch
3 times, most recently
from
225095e to
a56d36f
Compare
closes spring-projectsgh-16539 Signed-off-by: Daniel Garnier-Moiroux <[email protected]>
closes spring-projectsgh-16414 Signed-off-by: Daniel Garnier-Moiroux <[email protected]>
Kehrlann
force-pushed
the
ott/enable-default-ui-ott-only
branch
from
a56d36f to
95001c3
Compare
rwinch
added
in: web
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Addresses gh-16414 & gh-16539
reviewer: @rwinch
Notable
In the servlet stack only.
The filter that processes the token-based authentication has been changed to an
AbstractAuthenticationProcessingFilterinstead of an anonymous instance ofAuthenticationFilter.The
OneTimeTokenLoginConfiguercan therefore inherit fromAbstractAuthenticationFilterConfigurer, which configures the login entrypoint and the login page. The methods#authenticationFailureHandlerand#authenticationSuccessHandlerhave been deprecated in favor of those from the base class, but not marked for removal, I don't know what the policy is for removal.