Skip to content

Fix javadoc typo onResponseCommmitted-> onResponseCommitted #16535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 10, 2025
Merged

Fix javadoc typo onResponseCommmitted-> onResponseCommitted #16535

merged 1 commit into from
Feb 10, 2025

Conversation

LiYing2010
Copy link

changes

fix for typo

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Feb 4, 2025
@rwinch
Copy link
Member

rwinch commented Feb 10, 2025

Thanks for the PR @LiYing2010! Would you please sign the DCO as outlined in the CONTRIBUTING documentation so this can be merged? You can find the directions to fix it (sign the existing commit) in the Details link on the failed check.

@rwinch rwinch added status: waiting-for-feedback We need additional information before we can continue type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Feb 10, 2025
@rwinch rwinch self-assigned this Feb 10, 2025
@rwinch rwinch added this to the 6.5.0-M2 milestone Feb 10, 2025
@rwinch rwinch added the in: docs An issue in Documentation or samples label Feb 10, 2025
@rwinch rwinch changed the title fix for typo Fix javadoc typo onResponseCommmitted-> onResponseCommitted Feb 10, 2025
@rwinch rwinch enabled auto-merge (rebase) February 10, 2025 18:11
@rwinch rwinch merged commit 6494ea9 into spring-projects:main Feb 10, 2025
5 of 6 checks passed
@LiYing2010 LiYing2010 deleted the fix_for_typo branch February 13, 2025 04:28
@LiYing2010
Copy link
Author

LiYing2010 commented Feb 13, 2025 •
edited
Loading

@rwinch
sorry, I missed your comment

You can find the directions to fix it (sign the existing commit) in the Details link on the failed check.

sorry, looks like I need to rebase the working branch BEFORE PR get merged
but this PR is already merged into branch main now
is there anything I can do about my commit?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rwinch rwinch

Labels
in: docs An issue in Documentation or samples status: waiting-for-feedback We need additional information before we can continue type: bug A general bug
Projects
None yet
Milestone
6.5.0-M2
Development

Successfully merging this pull request may close these issues.
3 participants
@LiYing2010 @rwinch @spring-projects-issues