Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update doc: disable CSRF protection when using REST API for login. #16646

Closed
wants to merge 1 commit into from

Conversation

junjieyuan
Copy link

If CSRF protection is not disabled, Spring Security will return a 403 for the permitted /login API.

If CSRF protection is not disabled, Spring Security will return a 403 for the permitted `/login` API.

Signed-off-by: 原俊杰 <[email protected]>
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Feb 25, 2025
@sjohnr
Copy link
Member

sjohnr commented Feb 26, 2025

@junjieyuan thanks for the PR. However, this is not an improvement to the docs, as it is not recommended to disable CSRF without careful considerations which are listed elsewhere in the docs. I'm going to close this.

@sjohnr sjohnr closed this Feb 26, 2025
@sjohnr sjohnr self-assigned this Feb 26, 2025
@sjohnr sjohnr added in: docs An issue in Documentation or samples type: enhancement A general enhancement status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-triage An issue we've not yet triaged labels Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: docs An issue in Documentation or samples status: declined A suggestion or change that we don't feel we should currently apply type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants