Skip to content

Commit

Permalink
Adapt to deprecation
Browse files Browse the repository at this point in the history
  • Loading branch information
snicoll committed Feb 27, 2025
1 parent fb4ab82 commit 5a1e502
Show file tree
Hide file tree
Showing 38 changed files with 103 additions and 50 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
* </ul>
*
* @author Arjen Poutsma
* @see org.springframework.ws.server.endpoint.adapter.XPathParamAnnotationMethodEndpointAdapter
* @see org.springframework.ws.server.endpoint.adapter.method.XPathParamMethodArgumentResolver
* @since 1.0.0
*/
@Target(ElementType.PARAMETER)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
import java.io.ByteArrayInputStream;
import java.io.ByteArrayOutputStream;

import javax.xml.parsers.SAXParserFactory;
import javax.xml.transform.Source;
import javax.xml.transform.Templates;
import javax.xml.transform.Transformer;
Expand All @@ -30,7 +31,6 @@
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
import org.xml.sax.XMLReader;
import org.xml.sax.helpers.XMLReaderFactory;

import org.springframework.beans.factory.InitializingBean;
import org.springframework.core.io.Resource;
Expand Down Expand Up @@ -139,7 +139,9 @@ public void afterPropertiesSet() throws Exception {
throw new IllegalArgumentException("Setting either 'requestXslt' or 'responseXslt' is required");
}
TransformerFactory transformerFactory = getTransformerFactory();
XMLReader xmlReader = XMLReaderFactory.createXMLReader();
SAXParserFactory parserFactory = SAXParserFactory.newInstance();
parserFactory.setNamespaceAware(true);
XMLReader xmlReader = parserFactory.newSAXParser().getXMLReader();
xmlReader.setFeature("http://xml.org/sax/features/namespace-prefixes", true);
if (requestXslt != null) {
Assert.isTrue(requestXslt.exists(), "requestXslt \"" + requestXslt + "\" does not exit");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@

package org.springframework.ws.server.endpoint.mapping.jaxb;

import java.lang.reflect.InvocationTargetException;
import java.lang.reflect.Method;

import javax.xml.namespace.QName;
Expand Down Expand Up @@ -86,13 +87,13 @@ protected QName getLookupKeyForMethod(Method method) {

private QName handleRootElement(Class<?> parameterType) {
try {
Object param = parameterType.newInstance();
Object param = parameterType.getDeclaredConstructor().newInstance();
QName result = getElementName(parameterType, param);
if (result != null) {
return result;
}
}
catch (InstantiationException | IllegalAccessException e) {
catch (InvocationTargetException | NoSuchMethodException | InstantiationException | IllegalAccessException e) {
// ignore
}
return null;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -323,6 +323,7 @@ protected void onRefresh(ApplicationContext context) {
}

@Override
@SuppressWarnings("deprecation")
protected long getLastModified(HttpServletRequest httpServletRequest) {
WsdlDefinition definition = getWsdlDefinition(httpServletRequest);
if (definition != null) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ public class WebServiceMessageReceiverHandlerAdapter extends WebServiceMessageRe
implements HandlerAdapter {

@Override
@Deprecated
public long getLastModified(HttpServletRequest request, Object handler) {
return -1L;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,7 @@ public void setTransformSchemaLocations(boolean transformSchemaLocations) {
}

@Override
@Deprecated
public long getLastModified(HttpServletRequest request, Object handler) {
Source definitionSource = ((WsdlDefinition) handler).getSource();
return LastModifiedHelper.getLastModified(definitionSource);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,7 @@ public void setTransformSchemaLocations(boolean transformSchemaLocations) {
}

@Override
@Deprecated
public long getLastModified(HttpServletRequest request, Object handler) {
Source schemaSource = ((XsdSchema) handler).getSource();
return LastModifiedHelper.getLastModified(schemaSource);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,12 @@

import java.io.IOException;

import javax.xml.parsers.ParserConfigurationException;
import javax.xml.parsers.SAXParserFactory;
import javax.xml.transform.Source;

import org.xml.sax.SAXException;
import org.xml.sax.XMLReader;
import org.xml.sax.helpers.XMLReaderFactory;

import org.springframework.beans.factory.InitializingBean;
import org.springframework.core.io.Resource;
Expand Down Expand Up @@ -72,11 +73,13 @@ public void afterPropertiesSet() throws Exception {
@Override
public Source getSource() {
try {
XMLReader xmlReader = XMLReaderFactory.createXMLReader();
SAXParserFactory parserFactory = SAXParserFactory.newInstance();
parserFactory.setNamespaceAware(true);
XMLReader xmlReader = parserFactory.newSAXParser().getXMLReader();
xmlReader.setFeature("http://xml.org/sax/features/namespace-prefixes", true);
return new ResourceSource(xmlReader, wsdlResource);
}
catch (SAXException ex) {
catch (SAXException | ParserConfigurationException ex) {
throw new WsdlDefinitionException("Could not create XMLReader", ex);
}
catch (IOException ex) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@

import javax.xml.parsers.DocumentBuilder;
import javax.xml.parsers.DocumentBuilderFactory;
import javax.xml.parsers.SAXParserFactory;
import javax.xml.stream.XMLEventReader;
import javax.xml.stream.XMLEventWriter;
import javax.xml.stream.XMLInputFactory;
Expand All @@ -48,7 +49,6 @@
import org.xml.sax.InputSource;
import org.xml.sax.XMLReader;
import org.xml.sax.helpers.DefaultHandler;
import org.xml.sax.helpers.XMLReaderFactory;

import org.springframework.core.io.ClassPathResource;
import org.springframework.core.io.Resource;
Expand Down Expand Up @@ -187,8 +187,9 @@ public void testStreamReaderPayload() throws Exception {
}

private void validateMessage() throws Exception {

XMLReader xmlReader = XMLReaderFactory.createXMLReader();
SAXParserFactory parserFactory = SAXParserFactory.newInstance();
parserFactory.setNamespaceAware(true);
XMLReader xmlReader = parserFactory.newSAXParser().getXMLReader();
xmlReader.setContentHandler(new DefaultHandler());
ByteArrayOutputStream os = new ByteArrayOutputStream();
webServiceMessage.writeTo(os);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@

import static org.assertj.core.api.Assertions.assertThat;

@Deprecated
public class WebServiceNamespaceHandlerTest {

private ApplicationContext applicationContext;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@

import static org.assertj.core.api.Assertions.assertThat;

@Deprecated
public class WebServicesNamespaceHandlerTigerTest {

private ApplicationContext applicationContext;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@

import javax.xml.parsers.DocumentBuilder;
import javax.xml.parsers.DocumentBuilderFactory;
import javax.xml.parsers.SAXParserFactory;
import javax.xml.stream.XMLEventReader;
import javax.xml.stream.XMLInputFactory;
import javax.xml.stream.XMLStreamReader;
Expand All @@ -36,7 +37,6 @@
import org.w3c.dom.Document;
import org.xml.sax.InputSource;
import org.xml.sax.XMLReader;
import org.xml.sax.helpers.XMLReaderFactory;

import org.springframework.util.xml.StaxUtils;
import org.springframework.xml.DocumentBuilderFactoryUtils;
Expand Down Expand Up @@ -67,8 +67,9 @@ public void testDomSource() throws Exception {

@Test
public void testSaxSource() throws Exception {

XMLReader reader = XMLReaderFactory.createXMLReader();
SAXParserFactory parserFactory = SAXParserFactory.newInstance();
parserFactory.setNamespaceAware(true);
XMLReader reader = parserFactory.newSAXParser().getXMLReader();
InputSource inputSource = new InputSource(new StringReader(REQUEST));
testSource(new SAXSource(reader, inputSource));
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,12 @@

package org.springframework.ws.server.endpoint;

import static org.assertj.core.api.Assertions.*;

import org.dom4j.Document;
import org.dom4j.Element;

import static org.assertj.core.api.Assertions.assertThat;

@Deprecated
public class Dom4jPayloadEndpointTest extends AbstractPayloadEndpointTest {

@Override
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@

import static org.assertj.core.api.Assertions.assertThat;

@Deprecated
public class DomPayloadEndpointTest extends AbstractPayloadEndpointTest {

@Override
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@

import static org.assertj.core.api.Assertions.assertThat;

@Deprecated
public class JDomPayloadEndpointTest extends AbstractPayloadEndpointTest {

@Override
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@
import static org.easymock.EasyMock.replay;
import static org.easymock.EasyMock.verify;

@Deprecated
public class MarshallingPayloadEndpointTest {

private Transformer transformer;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
import static org.assertj.core.api.Assertions.assertThat;
import static org.assertj.core.api.Assertions.fail;

@Deprecated
public class SaxPayloadEndpointTest extends AbstractPayloadEndpointTest {

@Override
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
*
* @see AbstractStaxEventPayloadEndpoint
*/
@SuppressWarnings("Since15")
@Deprecated
public class StaxEventPayloadEndpointTest extends AbstractMessageEndpointTest {

@Override
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,32 +16,32 @@

package org.springframework.ws.server.endpoint;

import static org.assertj.core.api.Assertions.*;

import jakarta.xml.soap.MessageFactory;

import javax.xml.stream.XMLOutputFactory;
import javax.xml.stream.XMLStreamConstants;
import javax.xml.stream.XMLStreamReader;
import javax.xml.stream.XMLStreamWriter;
import javax.xml.transform.Transformer;

import jakarta.xml.soap.MessageFactory;
import org.junit.jupiter.api.Test;
import org.xmlunit.assertj.XmlAssert;

import org.springframework.ws.context.DefaultMessageContext;
import org.springframework.ws.context.MessageContext;
import org.springframework.ws.soap.saaj.SaajSoapMessage;
import org.springframework.ws.soap.saaj.SaajSoapMessageFactory;
import org.springframework.xml.transform.StringResult;
import org.springframework.xml.transform.StringSource;
import org.springframework.xml.transform.TransformerFactoryUtils;
import org.xmlunit.assertj.XmlAssert;

import static org.assertj.core.api.Assertions.assertThat;

/**
* Test case for AbstractStaxStreamPayloadEndpoint.
*
* @see AbstractStaxStreamPayloadEndpoint
*/
@SuppressWarnings("Since15")
@Deprecated
public class StaxStreamPayloadEndpointTest extends AbstractMessageEndpointTest {

@Override
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,11 @@

package org.springframework.ws.server.endpoint;

import static org.assertj.core.api.Assertions.*;

import nu.xom.Element;

import static org.assertj.core.api.Assertions.assertThat;

@Deprecated
public class XomPayloadEndpointTest extends AbstractPayloadEndpointTest {

@Override
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@
import static org.easymock.EasyMock.replay;
import static org.easymock.EasyMock.verify;

@Deprecated
public class GenericMarshallingMethodEndpointAdapterTest {

private GenericMarshallingMethodEndpointAdapter adapter;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@
import static org.easymock.EasyMock.replay;
import static org.easymock.EasyMock.verify;

@Deprecated
public class MarshallingMethodEndpointAdapterTest {

private MarshallingMethodEndpointAdapter adapter;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@

import static org.assertj.core.api.Assertions.assertThat;

@Deprecated
public class MessageMethodEndpointAdapterTest {

private MessageMethodEndpointAdapter adapter;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@

import static org.assertj.core.api.Assertions.assertThat;

@Deprecated
public class PayloadMethodEndpointAdapterTest {

private PayloadMethodEndpointAdapter adapter;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@
import static org.easymock.EasyMock.replay;
import static org.easymock.EasyMock.verify;

@Deprecated
public class XPathParamAnnotationMethodEndpointAdapterTest {

private static final String CONTENTS = "<root><child><text>text</text><number>42.0</number></child></root>";
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@
import static org.assertj.core.api.Assertions.assertThat;
import static org.assertj.core.api.Assertions.fail;

@Deprecated
public class FaultCreatingValidatingMarshallingPayloadEndpointTest {

private MessageContext messageContext;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
import java.util.Random;

import org.apache.commons.io.IOUtils;
import org.apache.commons.io.input.CountingInputStream;
import org.apache.commons.io.input.BoundedInputStream;
import org.junit.jupiter.api.Test;
import org.mockito.ArgumentCaptor;

Expand All @@ -46,11 +46,11 @@ public class AbstractHttpSenderConnectionTest {
* enabled.
*/
private void testSupportsStreaming(boolean chunking) throws Exception {

byte[] content = new byte[16 * 1024];
new Random().nextBytes(content);
CountingInputStream rawInputStream = new CountingInputStream(new ByteArrayInputStream(content));

BoundedInputStream rawInputStream = BoundedInputStream.builder()
.setInputStream(new ByteArrayInputStream(content))
.get();
AbstractHttpSenderConnection connection = spy(AbstractHttpSenderConnection.class);
when(connection.getResponseCode()).thenReturn(200);
// Simulate response with chunking enabled
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@
import org.springframework.ws.transport.WebServiceConnection;
import org.springframework.ws.transport.support.FreePortScanner;

@Deprecated
public class CommonsHttpMessageSenderIntegrationTest
extends AbstractHttpWebServiceMessageSenderIntegrationTest<CommonsHttpMessageSender> {

Expand All @@ -52,7 +53,7 @@ public void testMaxConnections() throws URIException {

CommonsHttpMessageSender messageSender = new CommonsHttpMessageSender();
messageSender.setMaxTotalConnections(2);
Map<String, String> maxConnectionsPerHost = new HashMap<String, String>();
Map<String, String> maxConnectionsPerHost = new HashMap<>();
maxConnectionsPerHost.put("https://www.example.com", "1");
maxConnectionsPerHost.put("http://www.example.com:8080", "7");
maxConnectionsPerHost.put("www.springframework.org", "10");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@

import static org.assertj.core.api.Assertions.assertThat;

@SuppressWarnings("deprecation")
public class HttpComponentsMessageSenderIntegrationTest
extends AbstractHttpWebServiceMessageSenderIntegrationTest<HttpComponentsMessageSender> {

Expand Down
Loading

0 comments on commit 5a1e502

Please sign in to comment.