Skip to content

Upgrade spring-ws-test XMLUnit from 1.5 to 2.x [SWS-1035] #1104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gregturn opened this issue Sep 5, 2018 · 5 comments
Closed

Upgrade spring-ws-test XMLUnit from 1.5 to 2.x [SWS-1035] #1104

gregturn opened this issue Sep 5, 2018 · 5 comments
Labels
status: duplicate A duplicate of another issue type: enhancement A general enhancement
Milestone
3.1.0-M1

Comments

@gregturn
Copy link
Contributor

gregturn commented Sep 5, 2018

Kees van Dieren opened SWS-1035 and commented

Spring-ws-test still depends on XMLUnit version 1.5. 

XMLUnit 2.x has already been integrated into Spring Framework: SPR-14043

Would be good to have the same version into spring webservices testing.

No further details from SWS-1035
@gregturn
Copy link
Contributor Author

Greg Turnquist commented

Given this would be a breaking change to spring-ws-test, it will have to wait until the next major release of Spring Web Services is started.

@gregturn
Copy link
Contributor Author

Leandro commented

Hi, at https://github.com/leaqui/spring-ws/tree/SWS-1035 I´ve made the migration to XMLUnit 2.6.2.

Is there a way to run CI tests over this branch without asking for a pull request?

@gregturn
Copy link
Contributor Author

gregturn commented Oct 18, 2018 •
edited
Loading

Leandro commented

Pull request created

#122

@gregturn gregturn added the type: enhancement A general enhancement label Sep 22, 2020
@gregturn gregturn added this to the 3.1 milestone Sep 22, 2020
@gregturn
Copy link
Contributor Author

This change will have to wait until Spring WS 3.1 is released.

@leaqui leaqui mentioned this issue Nov 14, 2020
Closed
@gregturn
Copy link
Contributor Author

gregturn commented Dec 1, 2020

Resolved via #1159.

@gregturn gregturn closed this as completed Dec 1, 2020
@gregturn gregturn added the status: duplicate A duplicate of another issue label Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: duplicate A duplicate of another issue type: enhancement A general enhancement
Projects
None yet
Milestone
3.1.0-M1
Development

No branches or pull requests
1 participant
@gregturn