Fix Nondeterministic Ordering in Tests #1166
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following tests:
org.springframework.ws.wsdl.wsdl11.DefaultWsdl11DefinitionTest#testSoap11And12 org.springframework.ws.wsdl.wsdl11.DefaultWsdl11DefinitionTest#testImport org.springframework.ws.wsdl.wsdl11.DefaultWsdl11DefinitionTest#testInclude org.springframework.ws.wsdl.wsdl11.DefaultWsdl11DefinitionTest#testSingle org.springframework.ws.wsdl.wsdl11.Wsdl4jDefinitionTest#testGetSource
are flaky tests.
.areIdentical()
not only compares the elements in XML, but also checks its order making the tests flaky.To fix this, instead of using
.areIdentical
orisIdentical
, we used.areSimilar
orisSimilar
since the order of the generated XML can be different every time.Build and unit tests pass:
