Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce httpcomponents httpclient5 support. #1356

Closed
wants to merge 8 commits into from
Closed

Introduce httpcomponents httpclient5 support. #1356

wants to merge 8 commits into from

Conversation

cachescrubber
Copy link
Contributor

Add support for Apache HttpClient 5.0

Fix #1164

gregturn and others added 4 commits May 11, 2023 12:31
@cachescrubber
Copy link
Contributor Author

cachescrubber commented May 12, 2023 •
edited
Loading

Notes

I removed the original HttpClient 3 based implementation CommonsHttpConnection, CommonsHttpMessageSender.

httpcomponent 4.5 support is still there.

I introduced HttpComponents5MessageSender and HttpComponents5Connection.

I separated the code to configure the HttpClient in a new FactoryBean, HttpComponents5ClientFactory . Using a factoryBean here might help folks still using xml configuration and provide compatibility to the current implementation.

In a spring-boot context I would recommend users to build the HttpClient by them self, using the various Builder supplied by httpcomponents.

The MR definitely needs polishing, I just want to check if it is going in the right direction.

Possible breaking changes.

  • AuthScope#ANY is no longer supported.

I would recommend to remove credentials / authscope support altogether and guide users to use an Interceptor based approach.

@cachescrubber cachescrubber mentioned this pull request May 12, 2023
Closed
Facedancer1984
Facedancer1984 reviewed May 12, 2023
View reviewed changes
gregturn pushed a commit that referenced this pull request May 12, 2023
@cachescrubber @gregturn
Introduce HttpComponents HttpClient 5 support.
4ebe0ba 
Resolves #1164.
Original Pull Request: #1356.
gregturn pushed a commit that referenced this pull request May 12, 2023
@cachescrubber @gregturn
Introduce HttpComponents HttpClient 5 support.
8e6eea7 
Resolves #1164.
Original Pull Request: #1356.

polish

polish
gregturn pushed a commit that referenced this pull request May 12, 2023
@cachescrubber @gregturn
Introduce HttpComponents HttpClient 5 support.
05daff5 
Resolves #1164.
Original Pull Request: #1356.

polish

polish

polish
@gregturn gregturn closed this May 12, 2023
gregturn pushed a commit that referenced this pull request May 12, 2023
@cachescrubber @gregturn
Introduce HttpComponents HttpClient 5 support.
2fecf02 
Resolves #1164.
Original Pull Request: #1356.
@cachescrubber cachescrubber deleted the hc5 branch May 13, 2023 04:29
@cachescrubber cachescrubber mentioned this pull request May 15, 2023
Closed
kmccarp pushed a commit to kmccarp/spring-projects__spring-ws that referenced this pull request Jun 5, 2023
@cachescrubber
Introduce HttpComponents HttpClient 5 support.
98bc09b 
Resolves spring-projects#1164.
Original Pull Request: spring-projects#1356.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Facedancer1984 Facedancer1984 Facedancer1984 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for Apache HttpClient 5.0
3 participants
@cachescrubber @Facedancer1984 @gregturn