Clearing context so later tests can pass #154
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@OrDTesters Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@OrDTesters This Pull Request contains an obvious fix. Signing the Contributor License Agreement is not necessary. |
|
Thank you for finding this @OrDTesters. However, it was also discovered by another member of the community and recently patched via eb6da13. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, tests in
SpringDigestPasswordValidationCallbackHandlerTestfail when they run right afterSpringSecurityPasswordValidationCallbackHandlerTest.testHandleUsernameTokenPrincipal. The proposed pull request inserts a call toSecurityContextHolder.clearContext()at the end oftestHandleUsernameTokenPrincipal(similar to how the call is in thetearDown()method inSpringDigestPasswordValidationCallbackHandlerTest), so the later tests can pass.@pivotal-issuemaster This is an Obvious Fix
Please let me know if you want to discuss the changes more.