-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No format for pom.xml in the Maven POM editor #1457
Comments
@foal Thanks for reporting, let's see if we can get to the bottom of this. So far I failed to reproduce this, installing a fresh Spring Tools 4 for Eclipse 4.27.0, starting it with an empty new workspace, creating a Rest Service guide project, opening the So we need to figure out what is different on your end that causes the |
I confirm the problem. I have did the following:
Here is my full configuration https://pastebin.com/QqMBfjBs |
For 4.28 on Windows - the same issue.
|
Do you have XML language server enabled? |
If it is enabled by default - yes. As I said I do not change nothing, just unpack, run import project and try to format pom.xml |
@anatoly-spb @foal Can you try to reproduce this with a plain Eclipse JEE 2024-12 installation from https://www.eclipse.org/downloads/packages/ (Since I can't reproduce this locally, I am trying to identify where the problem might be coming from, therefore the various checks to see where the root cause might be) |
@martinlippert Thank you for your time. I have downloaded https://www.eclipse.org/downloads/download.php?file=/technology/epp/downloads/release/2024-12/R/eclipse-java-2024-12-R-win32-x86_64.zip&mirror_id=1285 and there is no problem with formatting pom, it works as expected:
|
@martinlippert, yes, I can confirm in eclipse-jee-2024-12-R-win32-x86_64.zip the XML formatting on pom.xml works too from the box. |
I try to compare Spring Tool Suite 4.28.0.RELEASE with eclipse-jee-2024-12-R-win32-x86_64.zip. There are several remarks:
STS outputs only the following without messages from org.eclipse.wildwebdeveloper.xml:
May be it will be helpfull. |
The warning message in the log output around the binding for Ctrl-Shift-T is a know message and most likely unrelated to the formatting issue. But I am still puzzled why you are seeing this, but I don't and my colleague running a Windows box does also not see this issue... 🤔 You could try to see what happens if you install the Spring Tools into an existing, fresh Eclipse JEE package to see if that turns the existing and working Eclipse installation into one that doesn't work. That would at least give us a hint about whether the Spring Tools extension itself causes this or some additional plugins that the Spring Tools distribution has pre-installed. Other than that, I am slowly running out of ideas how to debug this remotely. |
@martinlippert I have installed the Spring Tool Suite 4.28.0.RELEASE on eclipse-jee-2024-12-R-win32-x86_64. Maven POM Editor does not format pom.xml after installation. I have attached the config difference report between before and after installation (unzip to see html report). |
@anatoly-spb @foal I am slowly running out of ideas here, but I am not willing to give up in this (yet)... :-) Can you a stepwise approach to installing the Spring Tools components into a vanilla Eclipse JEE 2024-12 package? This might at least give us a hint about which part of the Spring Tools add-ons cause this issue. The idea would be:
Is the format action still working or not after this? The idea is to find out which exact component install break the format action. Thanks again for your patience and help debugging this. Much appreciated. |
@martinlippert Thank you for your time. I have installed fresh Eclipse 2024-12 installation, installed Spring Boot Language Server Feature and after that Format does not work. |
Is content assist, validation still working in the POM editor? |
@BoykoAlex Thank you. Here is log org.eclipse.wildwebdeveloper.xml.zip the pom.xml:
There is one thing: Pom Xml is attached to Spring Boot Language Server: Is it ok? Pom Xml: Maven POM XML: |
How do you invoke the formatting action? Select all/range and then Ctrl-F/Cmd-F? |
@BoykoAlex I try both Ctrl+Shift+F and context menu Source/Format - nothing work. |
Do you see the |
@BoykoAlex I see nothing with textDocument/rangeFormatting. I have attached eclipse log and others inside log.zip |
Here is log from fresh Eclipse IDE installation. textDocument/rangeFormatting presents in .log file. Also in fresh Eclipse IDE only one Maven POM XML content type, after installation Spring there is Pom XML: Does it matter? |
Describe the bug
There is no option to format pom.xml in the Maven POM editor.
There is no Source menu with Format option, Ctrl+Shift+F does nothing.
Context menu contains Source -> Format Ctrl+Shift+F , but selection of this command also does nothing.
Spring Tool Suite 4
Version: 4.27.0.RELEASE
Build Id: 202411281622
Revision: a0cb489
A clear and concise description of what the bug is.
To Reproduce
In the XML editor the same file is formatted without any issues.
The text was updated successfully, but these errors were encountered: