Skip to content

Maintenance: update stub API for libdebug #2033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Maintenance: update stub API for libdebug #2033

wants to merge 1 commit into from

Conversation

yadij
Copy link
Contributor

@yadij yadij commented Mar 21, 2025

No description provided.

@yadij yadij added M-cleared-for-merge https://github.com/measurement-factory/anubis#pull-request-labels S-could-use-an-approval An approval may speed this PR merger (but is not required) labels Mar 21, 2025
@yadij yadij force-pushed the arc-libdebug-stubs branch from a0c9482 to 0728674 Compare March 21, 2025 09:11
@rousskov rousskov self-requested a review March 21, 2025 14:18
@rousskov rousskov added S-waiting-for-reviewer ready for review: Set this when requesting a (re)review using GitHub PR Reviewers box and removed S-could-use-an-approval An approval may speed this PR merger (but is not required) labels Mar 21, 2025
rousskov
rousskov requested changes Mar 28, 2025
View reviewed changes
src/tests/stub_libdebug.cc
void Debug::NameThisKid(int) STUB
void Debug::parseOptions(char const *) STUB
static std::ostringstream nilStream;
std::ostringstream &Debug::Start(const int, const int) STUB_RETVAL_NOP(nilStream)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kinkie, just for my own edification, why did you approve a PR that, AFAICT, silently disables basic debugging support in unit tests (that do not use a full debugging library -- libdebug.la)?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, missed that bit

@rousskov rousskov requested a review from kinkie March 28, 2025 14:53
@rousskov rousskov removed the M-cleared-for-merge https://github.com/measurement-factory/anubis#pull-request-labels label Mar 28, 2025
kinkie
kinkie requested changes Apr 6, 2025
View reviewed changes
Copy link
Contributor

@kinkie kinkie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As @rousskov noted, we need to preserve debug output in stub-linked files

@rousskov rousskov added S-waiting-for-author author action is expected (and usually required) and removed S-waiting-for-reviewer ready for review: Set this when requesting a (re)review using GitHub PR Reviewers box labels Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rousskov rousskov rousskov requested changes

@kinkie kinkie kinkie requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
S-waiting-for-author author action is expected (and usually required)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yadij @rousskov @kinkie