HTTP: update 1xx status handling #2048
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check Squid behaviour conforms to RFC 9110 and RFC 9112 requirements. Update code documentation to reference latest RFCs. Move 'can handle' logic to the HTTP Server object, most of the requirements rely on server state, not HTTP request message.
rousskov
requested changes
Apr 3, 2025
src/http.cc
Outdated
| // A server that receives an Upgrade header field in an | ||
| // HTTP/1.0 request MUST ignore that Upgrade field. | ||
| if (request->http_ver <= Http::ProtocolVersion(1,0)) | ||
| return "HTTP/1.0 does not suport Upgrade header field"; |
There was a problem hiding this comment.
Would Squid ever send a request that violates this MUST? If this check is really needed, it should go into request sending code, not response receiving code. If our sending code is correct, and we want to police versions in this case, then we can assert that the version is OK here.
There was a problem hiding this comment.
AFAIK today an ICAP/eCAP service can add Upgrade values which are blindly copied for delivery.
In future we may also want to proactively offer upgrades to better protocols (eg HTTPS, HTTP/2, etc).
This being a MUST requirement, IMO its worth checking to ensure we do not accidentally violate it.
Co-authored-by: Alex Rousskov <[email protected]>
yadij
added
the
S-waiting-for-reviewer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check Squid behaviour conforms to RFC 9110 and RFC 9112
requirements.
Update code documentation to reference latest RFCs.
Move 'can handle' logic to the HTTP Server object. Most of the
requirements are checking server state, not HTTP request
message.
Add performance optimization to 101 Switching Protocols logic.
Avoids memory setup for handling the Upgrade list header
unless the header actually exists and needs processing.
Do not send 1xx status when the client connection transport is
HTTP/1.0 or HTTP/0.9 unless client sent Expect:100-continue.