Skip to content

Fix #662: fix extending protocol from other namespace to nil #667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 9, 2025

Conversation

borkdude
Copy link
Member

@borkdude borkdude commented May 9, 2025

No description provided.

@borkdude borkdude requested a review from Copilot May 9, 2025 15:23
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request addresses issue #662 by fixing the behavior when extending protocols from a different namespace for a nil value. Key changes include:

  • Adjusting test assertions in compiler_test.cljs to verify the output when extending protocols on nil.
  • Updating internal protocols emission in protocols.cljc to properly qualify method names when a protocol symbol has an associated namespace.
  • Updating the changelog to document the fix.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
test/squint/compiler_test.cljs Modified test assertions to reflect the new handling of nil in protocols.
src/squint/internal/protocols.cljc Updated mname construction logic to qualify method names with the protocol namespace when applicable.
CHANGELOG.md Documented the fix for extending protocol from another namespace to nil.

@borkdude borkdude merged commit 795f8d9 into main May 9, 2025
6 checks passed
@borkdude borkdude deleted the issue-662 branch May 9, 2025 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant