Skip to content

Issue #1319: findnext inconsistency, option 1 #1320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

jrfnl
Copy link
Contributor

@jrfnl jrfnl commented Jan 28, 2017

Fixes #1319 with the smallest possible BC break.

@gsherwood
Copy link
Member

gsherwood commented Apr 5, 2017

I'm going to close the two PRs that provide options for #1319 because I only want to make a change like this in 3.x, and I'm not entirely sure which change yet. Discussion can continue over on the main issue.

@gsherwood gsherwood closed this Apr 5, 2017
@jrfnl
Copy link
Contributor Author

jrfnl commented Apr 5, 2017

@gsherwood Would you like me to pull these PRs against the v3 branch ?

@gsherwood
Copy link
Member

gsherwood commented Apr 5, 2017

Would you like me to pull these PRs against the v3 branch ?

No thanks. I don't see any reason for a PR until there is a decision about what change would be made. And I'm not going to make any changes before the 3.0 release anyway.

@jrfnl
Copy link
Contributor Author

jrfnl commented Apr 5, 2017

So what would you need to help you decide ? And what can I do to help ?

As this - as you correctly pointed out before - would be a BC break, this feels like something which should be in the 3.0.0 version and not in a later 3.x.

@gsherwood
Copy link
Member

this feels like something which should be in the 3.0.0 version and not in a later 3.x

It's just not going to be in 3.0. I'm not making a change that would require even more upgrades and another RC. I need to get it released, so this change is basically on hold for the time being.

@jrfnl
Copy link
Contributor Author

jrfnl commented Apr 5, 2017

On hold until version 4 in that case ?

@gsherwood
Copy link
Member

On hold until version 4 in that case ?

Maybe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants