This repository was archived by the owner on Oct 23, 2019. It is now read-only.
Update to latest remap-istanbul for bug fix #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulblyth
reviewed
Jan 23, 2018
package.json
Outdated
| @@ -27,7 +27,7 @@ | |||
| "url": "[email protected]:sshev/karma-remap-coverage.git" | |||
| }, | |||
| "dependencies": { | |||
| "remap-istanbul": "0.8.4" | |||
| "remap-istanbul": "0.10.1" | |||
There was a problem hiding this comment.
Worth putting a ^ so we get any patch fixes of 0.10.*?
There was a problem hiding this comment.
@paulblyth Sounds good to me, I'll update and rebase.
|
Updated to use |
|
@sshev any chance you could merge this PR and release? |
|
@paulblyth merged and published to npm as |
This was referenced Jan 29, 2018
|
Thanks @sshev and @mtraynham |
ejkj
pushed a commit
to ejkj/ngx-cookieconsent
that referenced
this pull request
May 29, 2018
Updates remap-istanbul with bug fixes sshev/karma-remap-coverage#23
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per SitePen/remap-istanbul#162, remap-istanbul had a dependency range issue with the latest 0.7.0 release of source-map and had to be updated. I've bumped the remap-instanbul dependency to 0.10.1 to pick up that fix.