-
Notifications
You must be signed in to change notification settings - Fork 599
Used sub-strategy. #7800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Used sub-strategy. #7800
Conversation
how come there is no inc? Code quote:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 6 of 56 files at r1, all commit messages.
Reviewable status: 6 of 56 files reviewed, 1 unresolved discussion (waiting on @orizi)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 6 of 56 files reviewed, 1 unresolved discussion (waiting on @ilyalesokhin-starkware)
crates/cairo-lang-sierra-generator/src/function_generator_test_data/snapshot
line 85 at r1 (raw file):
Previously, ilyalesokhin-starkware wrote…
how come there is no inc?
It is inlined now.
Previously, orizi wrote…
I still expect to see inc before trim, but I haven't digged into it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 9 of 56 files at r1.
Reviewable status: 15 of 56 files reviewed, 1 unresolved discussion (waiting on @orizi)
commit-id:34b56463
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 56 files at r1, all commit messages.
Reviewable status: 18 of 56 files reviewed, all discussions resolved
No description provided.