Skip to content

Used sub-strategy. #7800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Used sub-strategy. #7800

wants to merge 1 commit into from

Conversation

orizi
Copy link
Collaborator

@orizi orizi commented May 26, 2025

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

@orizi orizi force-pushed the spr/main/f1b731fa branch from fb62d85 to 7d6ff7c Compare May 26, 2025 12:27
@orizi orizi force-pushed the spr/main/34b56463 branch from 94b6d4d to c42495a Compare May 26, 2025 12:27
@orizi orizi force-pushed the spr/main/f1b731fa branch from 7d6ff7c to d1cef10 Compare May 26, 2025 14:07
@orizi orizi force-pushed the spr/main/34b56463 branch from c42495a to 9a9ce2e Compare May 26, 2025 14:07
@ilyalesokhin-starkware
Copy link
Contributor

crates/cairo-lang-sierra-generator/src/function_generator_test_data/snapshot line 85 at r1 (raw file):

dup<u32>([1]) -> ([1], [2])
rename<u32>([2]) -> ([3])
bounded_int_trim_max<u32>([3]) { fallthrough() label_test::foo::1([4]) }

how come there is no inc?

Code quote:

bounded_int_trim_max

Copy link
Contributor

@ilyalesokhin-starkware ilyalesokhin-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 56 files at r1, all commit messages.
Reviewable status: 6 of 56 files reviewed, 1 unresolved discussion (waiting on @orizi)

Copy link
Collaborator Author

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 6 of 56 files reviewed, 1 unresolved discussion (waiting on @ilyalesokhin-starkware)


crates/cairo-lang-sierra-generator/src/function_generator_test_data/snapshot line 85 at r1 (raw file):

Previously, ilyalesokhin-starkware wrote…

how come there is no inc?

It is inlined now.

@orizi orizi force-pushed the spr/main/34b56463 branch from 9a9ce2e to fd3373f Compare May 29, 2025 08:31
@orizi orizi force-pushed the spr/main/f1b731fa branch from d1cef10 to b56b4df Compare May 29, 2025 08:31
@ilyalesokhin-starkware
Copy link
Contributor

crates/cairo-lang-sierra-generator/src/function_generator_test_data/snapshot line 85 at r1 (raw file):

Previously, orizi wrote…

It is inlined now.

I still expect to see inc before trim, but I haven't digged into it.

Copy link
Contributor

@ilyalesokhin-starkware ilyalesokhin-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 9 of 56 files at r1.
Reviewable status: 15 of 56 files reviewed, 1 unresolved discussion (waiting on @orizi)

@orizi orizi changed the base branch from spr/main/f1b731fa to main May 31, 2025 17:08
@orizi orizi force-pushed the spr/main/34b56463 branch from fd3373f to da7001a Compare May 31, 2025 17:08
@orizi orizi changed the base branch from main to spr/main/422b1855 May 31, 2025 17:08
@orizi orizi force-pushed the spr/main/422b1855 branch from ebc7116 to b61c1e5 Compare June 3, 2025 07:17
@orizi orizi force-pushed the spr/main/34b56463 branch from da7001a to 5eeb444 Compare June 3, 2025 07:17
@orizi orizi changed the base branch from spr/main/422b1855 to main June 4, 2025 07:43
@orizi orizi force-pushed the spr/main/34b56463 branch from 5eeb444 to 8241d48 Compare June 4, 2025 07:43
@orizi orizi changed the title Added sub-strategy. Used sub-strategy. Jun 4, 2025
@orizi orizi changed the base branch from main to spr/main/fa6037c7 June 4, 2025 07:43
@orizi orizi mentioned this pull request Jun 4, 2025
@orizi orizi force-pushed the spr/main/34b56463 branch from 8241d48 to 6f81b07 Compare June 4, 2025 15:18
@orizi orizi force-pushed the spr/main/fa6037c7 branch from e94fa35 to c2b924f Compare June 4, 2025 15:18
@orizi orizi force-pushed the spr/main/34b56463 branch from 6f81b07 to 8902bbf Compare June 4, 2025 17:00
commit-id:34b56463
@orizi orizi force-pushed the spr/main/34b56463 branch from 8902bbf to c0e7475 Compare June 5, 2025 07:01
@orizi orizi changed the base branch from spr/main/fa6037c7 to main June 5, 2025 07:01
Copy link
Contributor

@ilyalesokhin-starkware ilyalesokhin-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 56 files at r1, all commit messages.
Reviewable status: 18 of 56 files reviewed, all discussions resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants