Skip to content

Updated allowed-libfuncs jsons to provide the minimal support version. #7844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: orizi/version-supports
Choose a base branch
from

Conversation

orizi
Copy link
Collaborator

@orizi orizi commented Jun 17, 2025

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

@ilyalesokhin-starkware
Copy link
Contributor

crates/cairo-lang-starknet-classes/src/contract_class.rs line 106 at r1 (raw file):

                        class_version,
                    });
                }

Suggestion:

                Some(Some(required_version))  => {
                    if class_version.major < required_version.major ||
                     (class_version.major == required_version.major
                        && class_version.minor < required_version.minor) {
                        return Err(AllowedLibfuncsError::UnsupportedLibfuncAtVersion {
                            invalid_libfunc: libfunc.long_id.generic_id.to_string(),
                            required_version: *required_version,
                            class_version,
                        });
                }

Copy link
Contributor

@ilyalesokhin-starkware ilyalesokhin-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 7 of 7 files at r1.
Reviewable status: all files reviewed (commit messages unreviewed), 1 unresolved discussion (waiting on @ArielElp, @liorgold2, and @orizi)

@orizi orizi force-pushed the orizi/update-allow-lists branch from ab16b1d to 5fe37e0 Compare June 18, 2025 10:05
@orizi orizi changed the base branch from main to orizi/version-supports June 18, 2025 10:05
Copy link
Collaborator Author

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 5 of 7 files reviewed, 1 unresolved discussion (waiting on @ArielElp, @ilyalesokhin-starkware, and @liorgold2)


crates/cairo-lang-starknet-classes/src/contract_class.rs line 106 at r1 (raw file):

                        class_version,
                    });
                }

Updated by rebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants