This repository was archived by the owner on May 8, 2025. It is now read-only.
Allow updating the pyenv global versions file #204
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
When setting the value of the
pyenv_global
variable to a different value than contained in the"{{ pyenv_path }}/version"
file, the global version file is not updated. This is probably because of the following condition : https://github.com/staticdev/ansible-role-pyenv/blob/main/tasks/install.yml#L91 which skips running the command when the file already exists (https://docs.ansible.com/ansible/latest/collections/ansible/builtin/shell_module.html#parameter-creates)We could remove that condition altogether, but this would always modify the file. We could also print & parse the globals as shown in this PR.
Let me know what you think!
(Also, thank you so much for maintaining this plugin!)