Skip to content

revise: have wdl-lint depend on wdl-analysis #341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Apr 28, 2025

Conversation

a-frantz
Copy link
Member

@a-frantz a-frantz commented Mar 7, 2025

Describe the problem or feature in addition to a link to the issues.

This PR exposes analysis (and type resolution) to wdl-lint. That required some very large refactors all over the codebase. I believe that I have ironed out all the issues, but let's kick the tires and what not before merging, because this is a lot of changes.

Before submitting this PR, please make sure:

  • You have added a few sentences describing the PR here.
  • You have added yourself or the appropriate individual as the assignee.
  • You have added at least one relevant code reviewer to the PR.
  • Your code builds clean without any errors or warnings.
  • You have added tests (when appropriate).
  • You have updated the README or other documentation to account for these
    changes (when appropriate).
  • You have added an entry to the relevant CHANGELOG.md (see
    "keep a changelog" for more information).
  • Your commit messages follow the conventional commit style.

@a-frantz a-frantz self-assigned this Mar 7, 2025
@claymcleod claymcleod changed the title refactor: have wdl-lint depend on wdl-analysis revise: have wdl-lint depend on wdl-analysis Mar 19, 2025
@a-frantz a-frantz force-pushed the refactor/analysis-in-wdl-lint branch 2 times, most recently from ce59b43 to d52bc32 Compare March 20, 2025 16:28
@claymcleod claymcleod force-pushed the main branch 3 times, most recently from 3dc8137 to f4c832c Compare March 26, 2025 01:07
@a-frantz a-frantz force-pushed the refactor/analysis-in-wdl-lint branch from d7baace to ce7bc31 Compare March 26, 2025 16:43
@a-frantz a-frantz linked an issue Mar 28, 2025 that may be closed by this pull request
@a-frantz a-frantz force-pushed the refactor/analysis-in-wdl-lint branch from 9721739 to 6a39704 Compare April 6, 2025 18:43
@github-actions github-actions bot added the S-awaiting-CI State: awaiting the CI to pass label Apr 6, 2025
@a-frantz a-frantz force-pushed the refactor/analysis-in-wdl-lint branch from 6a39704 to 67a12d2 Compare April 6, 2025 20:03
@github-actions github-actions bot added S-awaiting-CI State: awaiting the CI to pass and removed S-awaiting-CI State: awaiting the CI to pass labels Apr 6, 2025
@a-frantz a-frantz force-pushed the refactor/analysis-in-wdl-lint branch 4 times, most recently from d7c48c8 to 7ac5253 Compare April 18, 2025 16:54
@github-actions github-actions bot added S-awaiting-CI State: awaiting the CI to pass and removed S-awaiting-CI State: awaiting the CI to pass labels Apr 18, 2025
@a-frantz a-frantz force-pushed the refactor/analysis-in-wdl-lint branch from e0a0a5c to f2daab0 Compare April 21, 2025 15:54
@a-frantz a-frantz marked this pull request as ready for review April 21, 2025 15:57
Copy link
Collaborator

@peterhuene peterhuene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fantastic and I know was a huge effort to implement.

I have some comments, mostly minor stuff; the majority of the comments are duplicates where a simple thing was repeated.

@a-frantz a-frantz force-pushed the refactor/analysis-in-wdl-lint branch from fa1ca73 to 6a531f6 Compare April 27, 2025 19:28
@github-actions github-actions bot added the S-awaiting-CI State: awaiting the CI to pass label Apr 27, 2025
Copy link
Collaborator

@peterhuene peterhuene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@peterhuene
Copy link
Collaborator

re: CI failure, I think we can ignore it for this PR and create a separate fix for it.

@a-frantz a-frantz merged commit 0682dca into main Apr 28, 2025
17 of 18 checks passed
@a-frantz a-frantz deleted the refactor/analysis-in-wdl-lint branch April 28, 2025 17:45
@a-frantz a-frantz restored the refactor/analysis-in-wdl-lint branch April 28, 2025 17:48
@a-frantz a-frantz deleted the refactor/analysis-in-wdl-lint branch April 28, 2025 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-awaiting-CI State: awaiting the CI to pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor wdl-lint on top of wdl-analysis
4 participants