-
Notifications
You must be signed in to change notification settings - Fork 34
revise: have wdl-lint
depend on wdl-analysis
#341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
wdl-lint
depend on wdl-analysis
ce59b43
to
d52bc32
Compare
3dc8137
to
f4c832c
Compare
d7baace
to
ce7bc31
Compare
9721739
to
6a39704
Compare
6a39704
to
67a12d2
Compare
d7c48c8
to
7ac5253
Compare
e0a0a5c
to
f2daab0
Compare
a74e03c
to
cea96d0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fantastic and I know was a huge effort to implement.
I have some comments, mostly minor stuff; the majority of the comments are duplicates where a simple thing was repeated.
Co-authored-by: Peter Huene <[email protected]>
fa1ca73
to
6a531f6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
re: CI failure, I think we can ignore it for this PR and create a separate fix for it. |
Describe the problem or feature in addition to a link to the issues.
This PR exposes analysis (and type resolution) to
wdl-lint
. That required some very large refactors all over the codebase. I believe that I have ironed out all the issues, but let's kick the tires and what not before merging, because this is a lot of changes.Before submitting this PR, please make sure:
changes (when appropriate).
CHANGELOG.md
(see"keep a changelog" for more information).