fix(cli): throw error if no file found to lint

[christopher-ayling]

Fixes #2675.

Checklist

• Tests added / updated
• Docs added / updated

Does this PR introduce a breaking change?

• Yes Maybe?
• No

The cli used to show a success message if you passed a file to lint that didn't exist, leading you to believe everything was ok, when in fact no linting had been done. Now this throw's an error.

Screenshots
before:

after:

[christopher-ayling]

Unable to get any harness tests to pass, even on the develop branch. Have run yarn build && yarn workspace @stoplight/spectral-cli build.binary before running yarn test.harness. still no luck

[mnaumanali94]

@christopher-ayling We'll take a look at this and get back to you. Have you considered the case where the value is a glob instead of a file path? Should it fail in that case? 🤔

[YOU54F]

Hey @christopher-ayling,

Did you manage to get your test harness to run locally?

Happy to take a look at that with you.

Any thoughts on @mnaumanali94's question above?

[YOU54F]

Unable to get any harness tests to pass, even on the develop branch. Have run yarn build && yarn workspace @stoplight/spectral-cli build.binary before running yarn test.harness. still no luck

Looks like the same question was asked in another PR, wonder if this may help for you.

#2737 (comment)

I'll check the instructions for running locally, and update where appropriate in order to get a nice out of the box experience for contributors :)

Appreciate the change

[YOU54F]

It actually looks like the test harness fails on node 20 upwards, and is excluded from testing the harness in CI, for node 20. It tests against lts releases and uses node 16/18 for the lts versions.

node 16 is already eol and node 18 is going eol in 2 weeks.

switching to node 18, gives me a green test harness