Skip to content

chore: Eslint v9 #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Oct 28, 2024
Merged

chore: Eslint v9 #24

merged 20 commits into from
Oct 28, 2024

Conversation

teogeb
Copy link
Collaborator

@teogeb teogeb commented Oct 28, 2024

Changes

Converted the configuration file to flat config and unified to config file style. Otherwise same rules are earlier, but some new rules disabled (see "Future improvements").

The bin directory is also now included as a source directory and therefore eslint checks also those files.

Also small changes to code to fix some eslint warnings. These modifications don't change any functionality.

Future improvements

  • Avoid using any type, i.e. enable these rules:
    • @typescript-eslint/no-unsafe-argument
    • @typescript-eslint/no-unsafe-assignment
    • @typescript-eslint/no-unsafe-call
    • @typescript-eslint/no-unsafe-member-access
    • @typescript-eslint/no-unsafe-return
  • Implement safer promise handling, i.e. enable these rules:
    • @typescript-eslint/no-floating-promises
    • @typescript-eslint/no-misused-promises
    • @typescript-eslint/require-await

@teogeb teogeb requested a review from jtakalai October 28, 2024 11:28
Base automatically changed from bump-v102.0.0-beta.0 to main October 28, 2024 12:42
@teogeb teogeb merged commit efc24de into main Oct 28, 2024
3 checks passed
@teogeb teogeb deleted the eslint-v9 branch October 28, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants