Remove Secret from ClusterCa generate cert methods #10915
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Katherine Stanley <[email protected]>
katheris
force-pushed
the
betterSeparationInCa
branch
from
330c87c to
93fa54c
Compare
|
/azp run regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
scholzj
reviewed
Dec 6, 2024
| Map<String, CertAndKey> existingCertificates, | ||
| Set<NodeRef> nodes, | ||
| boolean isMaintenanceTimeWindowsSatisfied, | ||
| boolean forceRenew |
There was a problem hiding this comment.
Here - as well as in the other methods below - you call it forceRenewe. But you pass into it the value hasCaCertGenerationChanged. Given force-renew is an annotation for force certificate renewal, I think we should rename this to better correspond to what indicates here? E.g. caCertGenerationChanged?
There was a problem hiding this comment.
Yeah I see your point, I've renamed it
Signed-off-by: Katherine Stanley <[email protected]>
scholzj
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Remove use of Secret object from ClusterCa generate certificate methods.
To support per-broker Secrets for certificates we need to separate the handling of the certificates from storing them in the Secret.
Support issue #7687
Checklist
Please go through this checklist and make sure all applicable tasks have been done