[ST] Specify correct registry, org, and tag for Helm and remove unused code for OCP

[im-konge]

Type of change

• Bugfix

Description

In #10947 I changed the default values for the image registry, org, and tag values -> from our specific values to the empty one. Together with that, the check for changing the image parts was changed as well.
Now, this works for the K8s clusters and regular installation type, but it doesn't work for Helm.

Also, I'm removing unused code for adding the image-puller role, as it was not used for a long time in our tests on OCP -> and now it caused issues with running the tests, when the STRIMZI_ORG was empty.

Checklist

• Make sure all tests pass

[im-konge]

/azp run helm-acceptance

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[im-konge]

@strimzi-ci run tests --profile=acceptance --install-type=bundle --cluster-version=4.17 --cluster-type=ocp

[strimzi-ci]

▶️ Build started - check Jenkins for more info. ▶️

[strimzi-ci]

❌ Test Summary ❌

TEST_PROFILE: acceptance
GROUPS:
TEST_CASE:
TOTAL: 25
PASS: 24
FAIL: 1
SKIP: 0
BUILD_NUMBER: 13
OCP_VERSION: 4.17
BUILD_IMAGES: false
FIPS_ENABLED: false
PARALLEL_COUNT: 5
EXCLUDED_GROUPS: loadbalancer,nodeport,olm

❗ Test Failures ❗

• testMirrorMaker2Metrics in io.strimzi.systemtest.metrics.MetricsST

Re-run command:
@strimzi-ci run tests --profile=acceptance --testcase=io.strimzi.systemtest.metrics.MetricsST#testMirrorMaker2Metrics

[im-konge]

@strimzi-ci run tests --profile=acceptance --install-type=olm --cluster-version=4.17 --cluster-type=ocp

[strimzi-ci]

▶️ Build started - check Jenkins for more info. ▶️

[strimzi-ci]

❌ Test Summary ❌

TEST_PROFILE: acceptance
GROUPS:
TEST_CASE:
TOTAL: 13
PASS: 0
FAIL: 13
SKIP: 0
BUILD_NUMBER: 14
OCP_VERSION: 4.17
BUILD_IMAGES: false
FIPS_ENABLED: false
PARALLEL_COUNT: 5
EXCLUDED_GROUPS: loadbalancer,nodeport,olm

❗ Test Failures ❗

• io.strimzi.systemtest.bridge.HttpBridgeTlsST
• io.strimzi.systemtest.connect.ConnectBuilderST
• testMultiNodeKafkaConnectWithConnectorCreation in io.strimzi.systemtest.connect.ConnectST
• testCruiseControlWithRebalanceResourceAndRefreshAnnotation in io.strimzi.systemtest.cruisecontrol.CruiseControlST
• testCustomSoloCertificatesForRoute in io.strimzi.systemtest.kafka.listeners.ListenersST
• io.strimzi.systemtest.metrics.MetricsST
• testMirrorMaker2TlsAndTlsClientAuth in io.strimzi.systemtest.mirrormaker.MirrorMaker2ST
• io.strimzi.systemtest.operators.user.UserST
• testKafkaScaleUpScaleDown in io.strimzi.systemtest.rollingupdate.RollingUpdateST
• testAutoRenewAllCaCertsTriggeredByAnno in io.strimzi.systemtest.security.SecurityST
• io.strimzi.systemtest.security.oauth.OauthTlsST

Re-run command:
@strimzi-ci run tests --profile=acceptance --testcase=io.strimzi.systemtest.bridge.HttpBridgeTlsST,io.strimzi.systemtest.connect.ConnectBuilderST,io.strimzi.systemtest.connect.ConnectST#testMultiNodeKafkaConnectWithConnectorCreation,io.strimzi.systemtest.cruisecontrol.CruiseControlST#testCruiseControlWithRebalanceResourceAndRefreshAnnotation,io.strimzi.systemtest.kafka.listeners.ListenersST#testCustomSoloCertificatesForRoute,io.strimzi.systemtest.metrics.MetricsST,io.strimzi.systemtest.mirrormaker.MirrorMaker2ST#testMirrorMaker2TlsAndTlsClientAuth,io.strimzi.systemtest.operators.user.UserST,io.strimzi.systemtest.rollingupdate.RollingUpdateST#testKafkaScaleUpScaleDown,io.strimzi.systemtest.security.SecurityST#testAutoRenewAllCaCertsTriggeredByAnno,io.strimzi.systemtest.security.oauth.OauthTlsST

[im-konge]

@strimzi-ci run tests --profile=acceptance --install-type=olm --cluster-version=4.17 --cluster-type=ocp

[strimzi-ci]

▶️ Build started - check Jenkins for more info. ▶️

[strimzi-ci]

❌ Test Summary ❌

TEST_PROFILE: acceptance
GROUPS:
TEST_CASE:
TOTAL: 30
PASS: 25
FAIL: 5
SKIP: 0
BUILD_NUMBER: 15
OCP_VERSION: 4.17
BUILD_IMAGES: false
FIPS_ENABLED: false
PARALLEL_COUNT: 5
EXCLUDED_GROUPS: loadbalancer,nodeport,olm

❗ Test Failures ❗

• io.strimzi.systemtest.bridge.HttpBridgeTlsST
• io.strimzi.systemtest.connect.ConnectBuilderST
• io.strimzi.systemtest.metrics.MetricsST
• io.strimzi.systemtest.operators.user.UserST
• io.strimzi.systemtest.security.oauth.OauthTlsST

Re-run command:
@strimzi-ci run tests --profile=acceptance --testcase=io.strimzi.systemtest.bridge.HttpBridgeTlsST,io.strimzi.systemtest.connect.ConnectBuilderST,io.strimzi.systemtest.metrics.MetricsST,io.strimzi.systemtest.operators.user.UserST,io.strimzi.systemtest.security.oauth.OauthTlsST

[strimzi-ci]

▶️ Build started - check Jenkins for more info. ▶️

[strimzi-ci]

✔️ Test Summary ✔️

TEST_PROFILE: acceptance
GROUPS:
TEST_CASE:
TOTAL: 25
PASS: 25
FAIL: 0
SKIP: 0
BUILD_NUMBER: 16
OCP_VERSION: 4.17
BUILD_IMAGES: false
FIPS_ENABLED: false
PARALLEL_COUNT: 5
EXCLUDED_GROUPS: loadbalancer,nodeport,olm