-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Add support for Kafka 4.0.0 #11176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Kafka 4.0.0 #11176
Conversation
/azp run upgrade |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run upgrade |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run regression |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run regression |
Azure Pipelines successfully started running 1 pipeline(s). |
cluster-operator/src/main/java/io/strimzi/operator/cluster/model/KafkaCluster.java
Outdated
Show resolved
Hide resolved
cluster-operator/src/main/java/io/strimzi/operator/cluster/operator/resource/KafkaRoller.java
Outdated
Show resolved
Hide resolved
operator-common/src/main/java/io/strimzi/operator/common/http/HealthCheckAndMetricsServer.java
Show resolved
Hide resolved
packaging/install/cluster-operator/060-Deployment-strimzi-cluster-operator.yaml
Show resolved
Hide resolved
systemtest/src/main/java/io/strimzi/systemtest/Environment.java
Outdated
Show resolved
Hide resolved
7dc62c4
to
84f1eb2
Compare
/azp run regression |
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Jakub Scholz <[email protected]>
Signed-off-by: Jakub Scholz <[email protected]>
Signed-off-by: Jakub Scholz <[email protected]>
6d906a9
to
f3532e2
Compare
Signed-off-by: Jakub Scholz <[email protected]>
/azp run upgrade |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run regression |
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Jakub Scholz <[email protected]>
/azp run regression |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run feature-gates-regression |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run upgrade |
1 similar comment
/azp run upgrade |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one nit otherwise it look good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one thing (but nothing important).
Thanks for going through all the test-cases and fixing the issues :)
systemtest/src/main/java/io/strimzi/systemtest/utils/kafkaUtils/KafkaConnectorUtils.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Jakub Scholz <[email protected]>
/azp run regression |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run upgrade |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks Jakub!
Type of change
Description
This PR adds support for Kafka 4.0.0 to test the 4.0.0-RC0. The agreement is that this should be merged to allow further development and avoid rebasing.
The basic docs update with regards to the new Kafka version is done in this PR. But the larger docs update with regards to Log4j2 needs to be done separately.
The Kafka Agent has an issue because of backward incompatibilities between Jetty 9 used in Kafka 3 and Jetty 12 used in Kafka 4. The way this PR solves it is by creating two modules:
kafka-agent-3
for Kafka 3 with Jetty 9kafka-agent
for Kafka 4 with Jetty 12During the container image build, the right version is copied. Once we drop support for Kafka 3.9, we will simply delete the
kafka-agent-3
module.The log4j2 support relies on the Log4j2 reloading features instead of on Kafka APIs. The logging changes are also currently not fully documented and unit tested.
Checklist