fix: expose etag headers required for s3 multipart uploads in browser #691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fenos
approved these changes
May 13, 2025
itslenny
force-pushed
the
fix/expose-etag-headers-for-s3-multipart-upload
branch
from
83c199f to
7135540
Compare
itslenny
force-pushed
the
fix/expose-etag-headers-for-s3-multipart-upload
branch
from
7135540 to
2457b8a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
S3 multipart uploads cannot complete in browser because they are unable to access the etag header since it is not included in the
Access-Control-Expose-Headersof the response headersWhat is the new behavior?
Include etag in the
Access-Control-Expose-Headersfor only the S3 multipart upload requests. This allows using S3 multipart upload in browser.Additional context