fix: make empty bucket use queue to remove underlying objects asynchronously #701
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itslenny
force-pushed
the
fix/use-queue-in-empty-to-delete-objects
branch
from
1904a35 to
1d91784
Compare
Pull Request Test Coverage Report for Build 15352985493Details
💛 - Coveralls |
itslenny
force-pushed
the
fix/use-queue-in-empty-to-delete-objects
branch
from
3c757e7 to
d4c173d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
When a bucket is emptied it sends
DeleteObjectsCommandto S3 in a tight loop resulting in rate limit errors and ultimately orphan objects.What is the new behavior?
Use the queue to delete objects from the underlying object store asynchronously
Additional context
The
ObjectAdminDeleteBatchevent is directly copied fromObjectAdminDeletethe only difference being that it takes a list of prefixes to be passed directly intostorage.backend.deleteObjects(...)which maintains the same behavior for empty bucket as before the change, but utilizes the queue if available.