Skip to content

Remove Setters and Getters from Cluster's components #2802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Remove Setters and Getters from Cluster's components #2802

wants to merge 13 commits into from

Conversation

fnikolai
Copy link
Collaborator

Description

Related Issues

Checklist

  • Is this code covered by new or existing unit tests or integration tests?
  • Did you run make unit_testing and make integration-testing successfully?
  • Do new classes, functions, methods and parameters all have docstrings?
  • Were existing docstrings updated, if necessary?
  • Was external documentation updated, if necessary?

Additional Notes or Comments

@fnikolai fnikolai force-pushed the fix-ray branch 2 times, most recently from e050d4b to 36c3536 Compare April 18, 2025 14:40
@fnikolai fnikolai changed the title Fix ray tests-cases Fix Datalayer for multi-threading Apr 19, 2025
blythed
blythed approved these changes Apr 19, 2025
View reviewed changes
Copy link
Collaborator

@blythed blythed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a smart fix. Can you explain the logic why this fixes the feature?

fnikolai added 3 commits April 22, 2025 10:42
@fnikolai
Fix data layer for multi threading
9df2900 
Signed-off-by: Fotis Nikolaidis <[email protected]>

# Conflicts:
#	plugins/sql/superduper_sql/data_backend.py
@fnikolai
perform linting
ea42e4c 
Signed-off-by: Fotis Nikolaidis <[email protected]>
@fnikolai
remove setters and getters
8d76ca4 
Signed-off-by: Fotis Nikolaidis <[email protected]>
@fnikolai
remove setters and getters
f521324 
Signed-off-by: Fotis Nikolaidis <[email protected]>
@fnikolai fnikolai changed the title Fix Datalayer for multi-threading Remove Setters and Getters from Cluster's components Apr 22, 2025
fnikolai added 9 commits April 22, 2025 22:25
@fnikolai
fix concurrency on vector search
42b06c2 
Signed-off-by: Fotis Nikolaidis <[email protected]>
@fnikolai
fix concurrency on vector search
a1ed4a9 
Signed-off-by: Fotis Nikolaidis <[email protected]>
@fnikolai
improve parallelization on vector search
c86c1c9 
Signed-off-by: Fotis Nikolaidis <[email protected]>
@fnikolai
checkpoint
c55ceb4 
Signed-off-by: Fotis Nikolaidis <[email protected]>
@fnikolai
update files to work without setters and getters
f4e8a40 
Signed-off-by: Fotis Nikolaidis <[email protected]>
@fnikolai
get all tests passing
6000213 
Signed-off-by: Fotis Nikolaidis <[email protected]>
@fnikolai
update changelog
8810a15 
Signed-off-by: Fotis Nikolaidis <[email protected]>
@fnikolai
log improvements
ada1faa 
Signed-off-by: Fotis Nikolaidis <[email protected]>
@fnikolai
lint code
7262005 
Signed-off-by: Fotis Nikolaidis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blythed blythed blythed approved these changes

@jieguangzhou jieguangzhou jieguangzhou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fnikolai @blythed @jieguangzhou