Skip to content

Add x-root-ancestor vendor extension boolean property to use inheritance w/o discriminator (see #6127). #7910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

SergeyLyakhov
Copy link
Contributor

PR checklist

[+] Read the contribution guidelines.
[+] Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
[+] Filed the PR against the correct branch: 3.0.0 branch for changes related to OpenAPI spec 3.0. Default: master.
[+] Copied the technical committee to review the pull request if your PR is targeting a particular programming language.
@bbdouglas @JFCote @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger
cc: @wing328

Description of the PR

Add mechanism to support inheritance w/o discriminator.
Vendor extension property x-root-ancestor: [true|false] should be used to annotate the root model of hierarchy:

   Root:
    x-root-ancestor: true
    allOf:
      - type: object
        properties:
          id:
            type: string

  Intermediate:
    allOf:
      - $ref: '#/definitions/Root'
      - type: object
        properties:
          name:
            type: string

  Leaf:
    allOf:
      - $ref: '#/definitions/Intermediate'
      - type: object
        properties:
          description:
            type: string

This PR is related to #7593, and reimplemented according to requirements explained in comments there.

@SergeyLyakhov SergeyLyakhov changed the title Add VE x-root-ancestor boolean property to use inheritance w/o discriminator (see #6127). Add x-root-ancestor vendor extension boolean property to use inheritance w/o discriminator (see #6127). May 9, 2018
@pnewhook
Copy link

Any chance of getting this merged? I'm interested in #7060

@Irene93
Copy link

Irene93 commented Mar 19, 2019

Is there any news about the release of this feature? Thank you

@TheOneValen
Copy link

This would really help with my Usecase, otherwise I can't use inheritance :-(

@rchalaszczyk
Copy link

Any chance for it? Needed for #7060

@HugoMario HugoMario self-assigned this Aug 14, 2020
@vlauciani
Copy link

Is there any news about this PR?

@vlauciani
Copy link

About the inheritance problem without using the discriminator, I found this workaround:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants