Skip to content

test: add specs for node loader #4295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

21 changes: 11 additions & 10 deletions crates/swc_ecma_loader/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -27,18 +27,19 @@ tsc = ["dashmap", "once_cell", "swc_cached"]
[dependencies]
ahash = "0.7.4"
anyhow = "1.0.41"
dashmap = {version = "5.1.0", optional = true}
lru = {version = "0.7.1", optional = true}
once_cell = {version = "1.9.0", optional = true}
parking_lot = {version = "0.12.0", optional = true}
path-clean = {version = "=0.1.0", optional = true}
serde = {version = "1", features = ["derive"]}
serde_json = {version = "1.0.64", optional = true}
swc_cached = {version = "0.1.0", optional = true, path = "../swc_cached"}
swc_common = { version = "0.17.20", path = "../swc_common"}
dashmap = { version = "5.1.0", optional = true }
lru = { version = "0.7.1", optional = true }
once_cell = { version = "1.9.0", optional = true }
parking_lot = { version = "0.12.0", optional = true }
path-clean = { version = "=0.1.0", optional = true }
serde = { version = "1", features = ["derive"] }
serde_json = { version = "1.0.64", optional = true }
swc_cached = { version = "0.1.0", optional = true, path = "../swc_cached" }
swc_common = { version = "0.17.20", path = "../swc_common" }
tracing = "0.1.32"

[dev-dependencies]
lazy_static = "1.4.0"

[target.'cfg(windows)'.dependencies]
normpath = {version = "0.2", optional = true}
normpath = { version = "0.2", optional = true }
1 change: 1 addition & 0 deletions crates/swc_ecma_loader/tests/.gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
!node_modules

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Empty file.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
{
"name": "app",
"main": "file.js"
}
68 changes: 68 additions & 0 deletions crates/swc_ecma_loader/tests/node_resolver.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,68 @@
#![cfg(feature = "node")]

use std::{
collections::HashMap,
env::{current_dir, set_current_dir},
path::PathBuf,
sync::{Arc, Mutex},
};

use anyhow::{anyhow, Error};
use lazy_static::lazy_static;
use swc_common::{collections::AHashMap, FileName};
extern crate swc_ecma_loader;
use swc_ecma_loader::{resolve::Resolve, resolvers::node::NodeModulesResolver, TargetEnv};

lazy_static! {
static ref UPDATE_DIR_MUTEX: Arc<Mutex<()>> = Arc::new(Mutex::new(()));
}

fn inside_directory(dir: &str, callback: fn()) {
let arc = Arc::clone(&UPDATE_DIR_MUTEX);
let _lock = arc.lock().expect("could not lock");

let initial_current_dir = current_dir().unwrap();
let new_current_dir = format!("{}{}", initial_current_dir.display(), dir);

set_current_dir(new_current_dir).unwrap();
callback();
set_current_dir(initial_current_dir).unwrap();
}

#[test]
fn basic_import() {
inside_directory("/tests/basic_import", || {
// Given
let node_resolver = NodeModulesResolver::new(TargetEnv::Node, Default::default(), true);

// When
let resolved = node_resolver
.resolve(&FileName::Real(PathBuf::from(&"jquery")), &"jquery")
.expect("should resolve");

// Expect
assert_eq!(
resolved,
FileName::Real(PathBuf::from("node_modules/jquery/index.js"))
);
});
}

#[test]
fn hoisting() {
inside_directory("/tests/hoisting/packages/app", || {
// Given
let node_resolver = NodeModulesResolver::new(TargetEnv::Node, Default::default(), true);

// When
let resolved = node_resolver
.resolve(&FileName::Real(PathBuf::from(&"jquery")), &"jquery")
.expect("should resolve");

// Expect
assert_eq!(
resolved,
FileName::Real(PathBuf::from("../../node_modules/jquery/index.js"))
);
});
}