A couple of improvements for generated interfaces #1460
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rename methods to highlight that we’re talking about generated interfaces here, not `.swiftinterface` files - Don’t open the generated interface in `documentManager`. Opening documents in `documentManager` should only be done by the `textDocument/didOpen` notification from the LSP client. Otherwise we might indefinitely keep the document in the document manager - After getting the generated interface from sourcekitd, close the document in sourcekitd again. We don’t provide semantic functionality in the generated interface yet, so we can’t interact with the generated interface path. Before, we left it open in sourcekitd indefinitely. - A couple of code simplifications. Fixes swiftlang#878 rdar://116705653
|
@swift-ci Please test |
hamishknight
approved these changes
Jun 10, 2024
Comment on lines
31
to
32
| // has interface already been generated | ||
| if let snapshot = try? self.documentManager.latestSnapshot(interfaceDocURI) { |
There was a problem hiding this comment.
Just to make sure I understand, once the client has opened the interface, it gets populated in the documentManager?
There was a problem hiding this comment.
Yes, the client should send a textDocument/didOpen notification to SourceKit-LSP, which will then add it to the document manager like any other source file.
bnbarham
approved these changes
Jun 10, 2024
Yes, we currently don’t provide any intelligent editor functionality in swift interfaces (#1155). |
This was referenced Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.swiftinterfacefilesdocumentManager. Opening documents indocumentManagershould only be done by thetextDocument/didOpennotification from the LSP client. Otherwise we might indefinitely keep the document in the document managerFixes #878
rdar://116705653