NFC: Move #includes out of extern "C" block
#58
Conversation
|
Is there a way we can add this to the CMake test suite so i can catch this in the future when integrating upstream changes or checking new work? |
|
Hello! Will this PR be merged in the codebase? We are trying to build a Swift dynamic library, to be used in C++, but the library depends on Thank you in advance and sorry for the disturb! |
This fixes a clang compiler error when using these headers in C++ language mode: ``` libcmark_gfm/include/registry.h:8:1: error: import of C++ module 'libcmark_gfm' appears within extern "C" language linkage specification #include "cmark-gfm.h" ``` rdar://109730567
egorzhdan
force-pushed
the
egorzhdan/include-inside-extern-c
branch
from
2403ee8 to
8a43e0a
Compare
|
Let me see if we could enable the Clang module verifier for this project. |
|
Unfortunately it doesn't look like we can use Clang's module verifier for this project, since the module verifier currently only supports frameworks and doesn't support static libraries. @QuietMisdreavus do you think we could land this change as is, or would you like to see an alternative way to test this? |
|
We can just land it as-is and deal with issues whenever they come up. Thanks for the PR! |
This fixes a clang compiler error when using these headers in C++ language mode:
rdar://109730567