Add enabled parameter in configuration #482
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -446,6 +446,7 @@ public function getConfigTreeBuilder(): TreeBuilder | |||
| ->end() | |||
| ->end() | |||
| ->scalarNode('id')->end() // service & rollbar | |||
| ->scalarNode('enabled')->defaultTrue()->end() | |||
There was a problem hiding this comment.
is it intended that this is not a booleanNode?
| @@ -75,6 +75,9 @@ public function load(array $configs, ContainerBuilder $container) | |||
| $handlers = []; | |||
|
|
|||
| foreach ($config['handlers'] as $name => $handler) { | |||
| if(false === $handler['enabled']) { | |||
There was a problem hiding this comment.
CS is broken
and if this is a boolean, there's no need for any comparisons:
Suggested change
| if(false === $handler['enabled']) { | |
| if (!$handler['enabled']) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature aims to separate the enabling of handlers based on the environment.
Use Case :
You have 3 servers on your project : dev, staging, and prod
Currently, you can't disable handlers for a specific environment. For an instance, you can't disable logging only in your staging environment.
With the enabled parameter, you are able to disable logging only in the staging environment.