Adding recipe for symfony/webpack-encore-bundle #458
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
suggested changes
Sep 9, 2018
Nyholm
reviewed
Sep 9, 2018
ghost
suggested changes
Sep 11, 2018
ghost
suggested changes
Sep 11, 2018
Koc
reviewed
Oct 4, 2018
| webpack_encore: | ||
| # The path where Encore is building the assets. | ||
| # This should match Encore.setOutputPath() in webpack.config.js. | ||
| output_path: '%kernel.public_dir%/build' |
There was a problem hiding this comment.
What about using two separate build directories per dev/prod env? It useful when you should testing in both modes in same time.
There was a problem hiding this comment.
I don't think that it's really common to run dev & prod at the same time in the same environment...
ghost
suggested changes
Oct 26, 2018
ghost
suggested changes
Oct 26, 2018
ghost
suggested changes
Oct 26, 2018
ghost
suggested changes
Oct 26, 2018
ghost
suggested changes
Nov 4, 2018
ghost
suggested changes
Nov 4, 2018
weaverryan
changed the title
ghost
suggested changes
Nov 5, 2018
ghost
suggested changes
Nov 5, 2018
ghost
deployed
to
|
This is ready for review - the bundle 1.0 has been released. The biggest change is moving the recipe from Update: re-added WIP so I can test what happens if I remove the pack. Thanks! |
weaverryan
changed the title
ghost
suggested changes
Nov 5, 2018
weaverryan
changed the title
|
This is ready to go. I just tested that if you remove |
javiereguiluz
approved these changes
Nov 5, 2018
weaverryan
added a commit
to symfony/symfony-docs
that referenced
this pull request
Nov 5, 2018
This PR was squashed before being merged into the 3.4 branch (closes #10322). Discussion ---------- [WCM] Encore updates for Webpack 4 Phew! The next (unreleased) version of Webpack Encore (will be 0.21.0) that supports Webpack 4 will contain a few minor changes, that have major implications on the documentation. Ultimately, I think the experience will be easier for users :). The 3 big changes are: 1) In all cases, people should use the new WebpackEncoreBundle and its 2 new Twig functions - `encore_entry_script_tags()` and `encore_entry_link_tags()` to render their `script` and `link` tags. 2) In earlier versions, an extra `manifest.js` file was output when using `createdSharedEntry()`. But now, a new `runtime.js` file is *always* output. But, because of the `encore_entry_script_tags()` shortcut... that's just rendered for you automatically. 3) `createSharedEntry()` is no longer hipster ;). This is from changes in Webpack. A newer, and better "split chunks" feature replaces it... which (other than changing how existing users think), is much simpler. Basically, the user does nothing... except call `encore_entry_script_tags()`. But, when this feature is enabled, the final `.js` and `.css` files may be split into multiple files. And so, the `encore_entry_script_tags()` (and also the link version) may render *multiple* script tags. This all happens automatically. TODO: Wait for the bundle to be tagged, then test the new recipe (symfony/recipes#458) and code through some of the docs to catch any mistakes (due to so many changes). **Merging into 4.1 TODOS** * update `web/` to `public/` Cheers! Commits ------- 12ca7d9 adding a small entry about ajax code splitting 165432f fixing build errors bf649ab Documenting copyFiles() and a few small things 6833bb6 finishing read-through c2b36a2 more work on encore 53f9ffe Adding docs for runtime.js and fixed a few other things 62f322e documenting the new split chunks and Twig helper functions for Encore
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys!
This is for the new bundle - https://github.com/symfony/webpack-encore-bundle.
This would replace the webpack-encore-pack recipe. Well, we won't delete that, but the idea would be that we would now install this bundle, not the pack.
Cheers!