Read data from an "entrypoints" key instead of the root of the entrypoints.json file #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @Lyrkan! |
weaverryan
added a commit
that referenced
this pull request
Nov 2, 2018
…the entrypoints.json file (Lyrkan) This PR was merged into the master branch. Discussion ---------- Read data from an "entrypoints" key instead of the root of the entrypoints.json file This PR changes how the `entrypoints.json` lookup works in order to support symfony/webpack-encore#424. Currently the entrypoints are directly listed at the root of the `entrypoints.json` file: ```json { "my_entry": { "js": [ "build/file1.js", "build/file2.js" ], "css": [ "build/styles.css", "build/styles2.css" ] }, "other_entry": { "js": [ "build/file1.js", "build/file3.js" ] } } ``` This works fine but will be a bit annoying later on if we want to add additional data such as [files hashes](symfony/webpack-encore#418) that could be used to automatically handle the `integrity` attribute of the generated `<script>` tags. A solution to that issue would be to move all the current data under an `entrypoints` key and add new keys when needed (for instance `hashes`): ```json { "entrypoints": { "my_entry": { "js": [ "build/file1.js", "build/file2.js" ], "css": [ "build/styles.css", "build/styles2.css" ] }, "other_entry": { "js": [ "build/file1.js", "build/file3.js" ] } } } ``` Commits ------- 97bcbae Put current data under an "entrypoints" key in the entrypoints.json file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes how the
entrypoints.jsonlookup works in order to support symfony/webpack-encore#424.Currently the entrypoints are directly listed at the root of the
entrypoints.jsonfile:{ "my_entry": { "js": [ "build/file1.js", "build/file2.js" ], "css": [ "build/styles.css", "build/styles2.css" ] }, "other_entry": { "js": [ "build/file1.js", "build/file3.js" ] } }This works fine but will be a bit annoying later on if we want to add additional data such as files hashes that could be used to automatically handle the
integrityattribute of the generated<script>tags.A solution to that issue would be to move all the current data under an
entrypointskey and add new keys when needed (for instancehashes):{ "entrypoints": { "my_entry": { "js": [ "build/file1.js", "build/file2.js" ], "css": [ "build/styles.css", "build/styles2.css" ] }, "other_entry": { "js": [ "build/file1.js", "build/file3.js" ] } } }