[0.21.0] shared js file content changes even if there is no code change

[jfcherng]

Problem

The js file content of shared entry (usually named as app.HASH.js or vendor.HASH.js) varies between builds even if there is no source code change.

Reproduce

https://github.com/jfcherng/encore-shared-content-unstable

[weaverryan]

This stuff is very complex - so it's very possible. We should check into it - thanks for the reproducer!

By the way, do you see a new hash EVERY time you build... even if you literally change NOTHING? Or do you at least need to change some content, but these 2 files are unchanged, and so should not have a new hash?

Thanks!

[jfcherng]

@weaverryan

I may run the build process even if there is no js code change (say I only edit some css files or other non-js assets whatever). Ideally, I hope the vendor.HASH.js remain the same file name and the same file content since I do not touch js-related things.

Currently, the file content would change (due to file content changes in _tmp_shared.HASH.js) but the HASH remains the same (because _tmp_shared.HASH.js is appened to vendor.HASH.js in the done compiler hook?). So I guess the more basic problem would be why the content of _tmp_shared.HASH.js changes between builds.

The generated codes still work fine though. The only inconvenience to me is that vendor.HASH.js would be marked as file content changed between builds in my assets version control.

[Lyrkan]

Maybe related to #361 (comment)?

[jfcherng]

@Lyrkan It looks quite similar.

In #361 @symfony/encore 0.21.0, there are unwanted changes between builds:

• _tmp_shared.js: content and hash
• shared.js: content (because _tmp_shared.js is appended to it in the done compiler hook)

[weaverryan]

Fixed in #441!

The issue was an internal detail of the "hack" that makes this work - a randomly-named file was created. This randomness caused the content/hash changed on _tmp_shared.js.