Add Encore.addAliases and Encore.addExternals methods #217
Conversation
|
Can you merge this!! |
|
Thanks @Lyrkan! Sorry for the wait :) |
…yrkan) This PR was merged into the master branch. Discussion ---------- Add Encore.addAliases and Encore.addExternals methods This PR adds two new methods to the API (closes #200): * **`Encore.addAliases`**: Adds the given values to the `resolve.alias` setting of the generated config * **`Encore.addExternals`**: Adds the given values to the `external` setting of the generated config Commits ------- eefe8a4 Add Encore.addAliases and Encore.addExternals methods
| @@ -77,7 +77,7 @@ class ConfigGenerator { | |||
|
|
|||
| config.resolve = { | |||
| extensions: ['.js', '.jsx', '.vue', '.ts', '.tsx'], | |||
| alias: {} | |||
| alias: this.webpackConfig.aliases | |||
There was a problem hiding this comment.
you should create a copy of it, so that modifying the generated webpack config object cannot modify the Encore config (which might be used again, even if it is probably only an edge case to reuse it without resetting).
this also applies to externals.
There was a problem hiding this comment.
Definitely, nice catch, I'll open a new PR for that.
I'm a bit worried that there is the same issue with other objects though... for instance when calling Encore.addLoader() and Encore.addPlugin().
There was a problem hiding this comment.
Well, if we don't mutate the object ourselves, it might be less of an issue. but here, we are doing the mutation ourselves in some cases
This PR adds two new methods to the API (closes #200):
Encore.addAliases: Adds the given values to theresolve.aliassetting of the generated configEncore.addExternals: Adds the given values to theexternalsetting of the generated config