Skip to content

save the accordion state in to preferences #1004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jferrer1W
Copy link
Contributor

PR Details

When the user collapse or expand the accordion, if He has configured a preferenceName , should be save the state of the accordion to preferences.

Description

  • I have to replaced div for button in order to use the click event correctly.
  • I have to create a method to save thre accordion state into preferences if the user has configure preference name.

Related Issue

#1001

Motivation and Context

The user must be able to save the state of the accordion in preferences.

How Has This Been Tested

  • With UnitTest
  • Manual

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the CONTRIBUTING document
  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly (README.md for each UI component)
  • I have added tests to cover my changes (at least 1 spec for each UI component with the same coverage as the master branch)
  • All new and existing tests passed
  • A new branch needs to be created from master to evolve previous versions
  • Increase version in package.json following Semantic Versioning
  • All UI components must be added into the showcase (at least 1 component with the default settings)
  • Add the issue into the right project with the proper status (In progress)

@jferrer1W jferrer1W self-assigned this Jun 10, 2025
@jferrer1W jferrer1W linked an issue Jun 10, 2025 that may be closed by this pull request
Copy link

codecov bot commented Jun 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.34%. Comparing base (c3a989f) to head (a763e9f).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1004      +/-   ##
==========================================
- Coverage   58.38%   58.34%   -0.05%     
==========================================
  Files         136      136              
  Lines        3809     3812       +3     
  Branches      677      678       +1     
==========================================
  Hits         2224     2224              
- Misses       1471     1474       +3     
  Partials      114      114              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accordion don't save this state in preferences
3 participants