Skip to content

New tooltip directive and component. Avoid using jQuery. #692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

alfonsserra
Copy link
Contributor

PR Details

Implement tooltips without using jQuery. Keep the same directive.

Related Issue

#691

Motivation and Context

There are few components with the jQuery dependency and we want to remove it.

How Has This Been Tested

Manual test

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the CONTRIBUTING document
  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly (README.md for each UI component)
  • I have added tests to cover my changes (at least 1 spec for each UI component with the same coverage as the master branch)
  • All new and existing tests passed
  • A new branch needs to be created from master to evolve previous versions
  • Increase version in package.json following Semantic Versioning
  • All UI components must be added into the showcase (at least 1 component with the default settings)
  • Add the issue into the right project with the proper status (In progress)

@codecov
Copy link

codecov bot commented Dec 29, 2022

Codecov Report

Base: 54.22% // Head: 54.74% // Increases project coverage by +0.52% 🎉

Coverage data is based on head (9384b7a) compared to base (059ebd1).
Patch coverage: 67.30% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #692      +/-   ##
==========================================
+ Coverage   54.22%   54.74%   +0.52%     
==========================================
  Files         125      126       +1     
  Lines        3471     3496      +25     
  Branches      601      602       +1     
==========================================
+ Hits         1882     1914      +32     
+ Misses       1485     1475      -10     
- Partials      104      107       +3     
Impacted Files Coverage Δ
...b-components/src/lib/systelab-components.module.ts 100.00% <ø> (ø)
...ab-components/src/lib/tooltip/tooltip.directive.ts 63.04% <63.04%> (+51.93%) ⬆️
...ab-components/src/lib/tooltip/tooltip.component.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

carlosra85
carlosra85 previously approved these changes Dec 29, 2022
jivanheerden
jivanheerden previously approved these changes Dec 30, 2022
@alfonsserra alfonsserra dismissed stale reviews from jivanheerden and carlosra85 via bb045a7 December 31, 2022 14:35
Copy link
Contributor

@oGalceran1 oGalceran1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Copy link
Contributor

@olgapuig olgapuig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvement @alfonsserra!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants