-
Notifications
You must be signed in to change notification settings - Fork 8
New tooltip directive and component. Avoid using jQuery. #692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportBase: 54.22% // Head: 54.74% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #692 +/- ##
==========================================
+ Coverage 54.22% 54.74% +0.52%
==========================================
Files 125 126 +1
Lines 3471 3496 +25
Branches 601 602 +1
==========================================
+ Hits 1882 1914 +32
+ Misses 1485 1475 -10
- Partials 104 107 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
projects/systelab-components/src/lib/tooltip/tooltip.directive.ts
Outdated
Show resolved
Hide resolved
bb045a7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the improvement @alfonsserra!!
PR Details
Implement tooltips without using jQuery. Keep the same directive.
Related Issue
#691
Motivation and Context
There are few components with the jQuery dependency and we want to remove it.
How Has This Been Tested
Manual test
Types of changes
Checklist