feat: single env file #1092

juliusmarminge · 2023-01-17T11:40:54Z

✅ Checklist

I have followed every step in the contributing guide (updated 2022-10-06).
The PR title follows the convention we established conventional-commit
I performed a functional test on my final commit

Changelog

Change to use a single env file as entry point. No need to import from server/client - we use a proxy to make sure the right errors are thrown if server vars are accessed on the client.

Screenshots

[Screenshots]

For example, if you try accessing env.DATABASE_URL on the client:

vercel · 2023-01-17T11:40:57Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Comments	Updated
create-t3-app	⬜️ Ignored (Inspect)	Visit Preview		Feb 6, 2023 at 11:25PM (UTC)

changeset-bot · 2023-01-17T11:40:58Z

🦋 Changeset detected

Latest commit: 8bb1294

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
create-t3-app	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2023-01-17T11:43:39Z

⚡️ Lighthouse report for the changes in this PR:

Category	Score
🟢 Performance	100
🟢 Accessibility	100
🟢 Best practices	100
🟢 SEO	93
🟠 PWA	54

Lighthouse ran on https://create-t3-app-git-julius-env-t3-oss.vercel.app/

cli/template/extras/src/env/with-auth.mjs

cli/template/extras/src/env/with-prisma.mjs

iduuck · 2023-01-20T09:58:14Z

Beside my two minor comments, I am sure that we could additionally use the type overwrite of process.env, if we want to. Though, we don't have the server vs. client type safety this way.

juliusmarminge · 2023-01-20T10:10:48Z

Beside my two minor comments, I am sure that we could additionally use the type overwrite of process.env, if we want to. Though, we don't have the server vs. client type safety this way.

I dont like the process.env typing since you miss stuff like default values for stuff your host provides, transforms/preprocess and other powerful primitives Zod provides besides the validation

add prop to error msg

c-ehrlich · 2023-01-20T14:50:41Z

Which use cases do we need to test to make sure that this works as desired?

dev
vercel
docker (passing in via docker-compose)
edge?
other?

github-actions · 2023-01-20T15:18:02Z

Hey t3-oss/translators!

This PR contains changes to your language. Please review the changes ❤️.

@a4addel @Sboonny @Defranos @joachimjusth @estubmo @josephayman @claudiofreitas @minsk-dev @Sn0wye @victoriaquasar @AmadeusTwi @ronanru @JohnBakhmat @fernandoxu @lodisy

Co-authored-by: Muhammed Mustafa <[email protected]>

…ulius/env

…into julius/env

juliusmarminge · 2023-02-06T23:27:53Z

Good on my side. Ship? @c-ehrlich

c-ehrlich · 2023-02-06T23:33:15Z

Good on my side. Ship? @c-ehrlich

yea good for me also

Sn0wye

LGTM!

* single env file * docs * fixy * better comments * serverside -> server-side add prop to error msg * dont crash when calling next-auth in gssp * add min(1) to all string schema * Update www/src/pages/ar/usage/env-variables.md Co-authored-by: Muhammed Mustafa <[email protected]> * simplify error formatting * allow empty strings for discord env vars * incorrect import * here also * add changeset * don't leak env keys in prod * fix bad merge * cleanup --------- Co-authored-by: Christopher Ehrlich <[email protected]> Co-authored-by: Muhammed Mustafa <[email protected]>

single env file

d44a430

github-actions bot added 📌 area: cli Relates to the CLI 📌 area: t3-app Relates to the generated T3 App 📚 documentation Improvements or additions to documentation labels Jan 17, 2023

Merge branch 'next' into julius/env

63dd47b

vercel bot deployed to Preview January 17, 2023 11:44 View deployment

docs

325e82e

vercel bot deployed to Preview January 17, 2023 12:24 View deployment

fixy

66fc368

vercel bot deployed to Preview January 17, 2023 12:28 View deployment

juliusmarminge marked this pull request as ready for review January 17, 2023 20:20

juliusmarminge requested review from nexxeln, t3dotgg and c-ehrlich as code owners January 17, 2023 20:20

Merge branch 'next' into julius/env

19d3c76

vercel bot deployed to Preview January 19, 2023 09:03 View deployment

better comments

841ca6d

iduuck reviewed Jan 20, 2023

View reviewed changes

cli/template/extras/src/env/with-auth.mjs Outdated Show resolved Hide resolved

cli/template/extras/src/env/with-prisma.mjs Outdated Show resolved Hide resolved

Merge branch 'next' into julius/env

4c98533

vercel bot deployed to Preview January 20, 2023 10:25 View deployment

serverside -> server-side

a06ec8a

add prop to error msg

juliusmarminge added the 🚀 autorelease add this label to a pr to trigger a beta release label Jan 20, 2023

github-actions bot removed the 🚀 autorelease add this label to a pr to trigger a beta release label Jan 20, 2023

Update www/src/pages/ar/usage/env-variables.md

16d6276

Co-authored-by: Muhammed Mustafa <[email protected]>

vercel bot had a problem deploying to Preview February 6, 2023 11:20 Failure

c-ehrlich added 2 commits February 6, 2023 18:04

simplify error formatting

95f6bd1

allow empty strings for discord env vars

080a039

vercel bot had a problem deploying to Preview February 6, 2023 17:08 Failure

c-ehrlich added 3 commits February 6, 2023 18:16

Merge branch 'next' of https://github.com/t3-oss/create-t3-app into j…

d2daed6

…ulius/env

incorrect import

5839247

here also

56d40fe

vercel bot deployed to Preview February 6, 2023 17:27 View deployment

Merge branch 'next' into julius/env

56e9ccb

vercel bot deployed to Preview February 6, 2023 21:56 View deployment

c-ehrlich added 2 commits February 6, 2023 23:16

add changeset

be2e016

Merge branch 'julius/env' of https://github.com/t3-oss/create-t3-app …

bb7f45a

…into julius/env

juliusmarminge added the 🚀 autorelease add this label to a pr to trigger a beta release label Feb 6, 2023

github-actions bot removed the 🚀 autorelease add this label to a pr to trigger a beta release label Feb 6, 2023

c-ehrlich and others added 3 commits February 7, 2023 00:03

don't leak env keys in prod

b014109

Merge branch 'next' into julius/env

afaf428

fix bad merge

152d34b

vercel bot deployed to Preview February 6, 2023 23:12 View deployment

juliusmarminge added the 🚀 autorelease add this label to a pr to trigger a beta release label Feb 6, 2023

github-actions bot removed the 🚀 autorelease add this label to a pr to trigger a beta release label Feb 6, 2023

cleanup

8bb1294

c-ehrlich approved these changes Feb 6, 2023

View reviewed changes

c-ehrlich merged commit aa44574 into next Feb 6, 2023

c-ehrlich deleted the julius/env branch February 6, 2023 23:36

github-actions bot mentioned this pull request Feb 6, 2023

chore(release): version packages #1172

Merged

Sn0wye reviewed Feb 7, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: single env file #1092

feat: single env file #1092

juliusmarminge commented Jan 17, 2023 •

edited

Loading

vercel bot commented Jan 17, 2023 •

edited

Loading

changeset-bot bot commented Jan 17, 2023 •

edited

Loading

github-actions bot commented Jan 17, 2023 •

edited

Loading

iduuck commented Jan 20, 2023

juliusmarminge commented Jan 20, 2023 •

edited

Loading

c-ehrlich commented Jan 20, 2023

github-actions bot commented Jan 20, 2023 •

edited

Loading

juliusmarminge commented Feb 6, 2023 •

edited

Loading

c-ehrlich commented Feb 6, 2023

Sn0wye left a comment

feat: single env file #1092

feat: single env file #1092

Conversation

juliusmarminge commented Jan 17, 2023 • edited Loading

✅ Checklist

Changelog

Screenshots

vercel bot commented Jan 17, 2023 • edited Loading

changeset-bot bot commented Jan 17, 2023 • edited Loading

🦋 Changeset detected

github-actions bot commented Jan 17, 2023 • edited Loading

iduuck commented Jan 20, 2023

juliusmarminge commented Jan 20, 2023 • edited Loading

c-ehrlich commented Jan 20, 2023

github-actions bot commented Jan 20, 2023 • edited Loading

juliusmarminge commented Feb 6, 2023 • edited Loading

c-ehrlich commented Feb 6, 2023

Sn0wye left a comment

Choose a reason for hiding this comment

juliusmarminge commented Jan 17, 2023 •

edited

Loading

vercel bot commented Jan 17, 2023 •

edited

Loading

changeset-bot bot commented Jan 17, 2023 •

edited

Loading

github-actions bot commented Jan 17, 2023 •

edited

Loading

juliusmarminge commented Jan 20, 2023 •

edited

Loading

github-actions bot commented Jan 20, 2023 •

edited

Loading

juliusmarminge commented Feb 6, 2023 •

edited

Loading