-
Notifications
You must be signed in to change notification settings - Fork 1.3k
feat: Add validation for import aliases #1255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 6b0539d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Running Lighthouse audit... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use the validate
prop instead of calling the prompter multipel times, see promptAppName
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now. Thanks for the contribution!
* feat: do not allow invalid import aliases * chore: add changeset * fix: use validate instead of custom logic * fix: update changeset to better match changes * refactor: change naming from path alias to import alias --------- Co-authored-by: Christopher Ehrlich <[email protected]>
Closes #
✅ Checklist
Changelog
Screenshots
💯