fix: typo in env.mjs #1690
Merged
fix: typo in env.mjs #1690
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c-ehrlich
requested review from
juliusmarminge,
nexxeln and
t3dotgg
as code owners
🦋 Changeset detectedLatest commit: 65ffcb6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
📌 area: cli
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://create-t3-app-git-env-typo-t3-oss.vercel.app/ |
| @@ -28,7 +28,7 @@ export const env = createEnv({ | |||
| // VERCEL_URL doesn't include `https` so it cant be validated as a URL | |||
| process.env.VERCEL ? z.string() : z.string().url() | |||
| ), | |||
| // Add ` on ID and SECRET if you want to make sure they're not empty | |||
| // Add `.min(1)` on ID and SECRET if you want to make sure they're not empty | |||
There was a problem hiding this comment.
This line isn't needed at all with the option below set to true
There was a problem hiding this comment.
Nah, u dont need to repair the 'string' one 💀💀💀
juliusmarminge
approved these changes
Dec 15, 2023
korawit-dvtx
pushed a commit
to korawit-dvtx/create-devviantex-nextjs-app-deprecated
that referenced
this pull request
Jun 9, 2024
Co-authored-by: juliusmarminge <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1677
✅ Checklist
Changelog
[Short description of what has changed]
Screenshots
[Screenshots]
💯