Skip to content

docs: update first steps #717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 12, 2022
Merged

docs: update first steps #717

merged 7 commits into from
Nov 12, 2022

Conversation

robotkutya
Copy link
Contributor

@robotkutya robotkutya commented Nov 10, 2022

  1. step is missing and needed

as per
https://www.nexxel.dev/blog/ct3a-guestbook#setting-up-authentication

Closes #

✅ Checklist

  • I have followed every step in the contributing guide (updated 2022-10-06).
  • The PR title follows the convention we established conventional-commit
  • I performed a functional test on my final commit

Changelog

Following the 7. steps in the beta docs section "First Steps" does not work -- you can not log in via Discord Auth Provider.

I added an 8th step based on
https://www.nexxel.dev/blog/ct3a-guestbook#setting-up-authentication
to ensure a good first experience for new adapters.


Screenshots

[Screenshots]

💯

@changeset-bot
Copy link

changeset-bot bot commented Nov 10, 2022

🦋 Changeset detected

Latest commit: b5749f2

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Nov 10, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
create-t3-app ✅ Ready (Inspect) Visit Preview Nov 12, 2022 at 9:30AM (UTC)

@github-actions github-actions bot added the 📚 documentation Improvements or additions to documentation label Nov 10, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 10, 2022

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 100
🟢 Accessibility 98
🟢 Best practices 93
🟠 SEO 86
🟠 PWA 54

Lighthouse ran on https://create-t3-app-git-fork-robotkutya-patch-1-t3-oss.vercel.app/

@robotkutya robotkutya changed the title Update First Steps docs: update first steps Nov 10, 2022
Copy link
Member

@c-ehrlich c-ehrlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this :)

Co-authored-by: Christopher Ehrlich <[email protected]>
@github-actions github-actions bot added 📌 area: cli Relates to the CLI 📌 area: t3-app Relates to the generated T3 App labels Nov 11, 2022
@juliusmarminge juliusmarminge enabled auto-merge (squash) November 12, 2022 09:34
Copy link
Member

@c-ehrlich c-ehrlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, lets merge :)

@juliusmarminge juliusmarminge merged commit 7f8e706 into t3-oss:next Nov 12, 2022
korawit-dvtx pushed a commit to korawit-dvtx/create-devviantex-nextjs-app-deprecated that referenced this pull request Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📌 area: cli Relates to the CLI 📌 area: t3-app Relates to the generated T3 App 📚 documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants