Skip to content

feat: render warning when using a tagged or outdated version #727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Nov 14, 2022
Merged

feat: render warning when using a tagged or outdated version #727

merged 12 commits into from
Nov 14, 2022

Conversation

juliusmarminge
Copy link
Member

Closes #

✅ Checklist

  • I have followed every step in the contributing guide (updated 2022-10-06).
  • The PR title follows the convention we established conventional-commit
  • I performed a functional test on my final commit

Changelog

[Short description of what has changed]

Screenshots

[Screenshots]

💯

@vercel
Copy link

vercel bot commented Nov 13, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
create-t3-app ✅ Ready (Inspect) Visit Preview Nov 13, 2022 at 8:31PM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Nov 13, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: 66f163b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-t3-app Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@juliusmarminge juliusmarminge added the 🚀 autorelease add this label to a pr to trigger a beta release label Nov 13, 2022
@github-actions github-actions bot added the 📌 area: cli Relates to the CLI label Nov 13, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 13, 2022 •
edited
Loading

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 98
🟢 Accessibility 98
🟢 Best practices 93
🟠 SEO 86
🟠 PWA 54

Lighthouse ran on https://create-t3-app-git-version-warning-t3-oss.vercel.app/

@juliusmarminge
Copy link
Member Author

CleanShot 2022-11-13 at 12 10 15@2x

@github-actions
Copy link
Contributor

github-actions bot commented Nov 13, 2022 •
edited
Loading

A new create-t3-app prerelease is available for testing. You can install this latest build in your project with:

npx [email protected]

@github-actions github-actions bot removed the 🚀 autorelease add this label to a pr to trigger a beta release label Nov 13, 2022
@juliusmarminge juliusmarminge added the 🚀 autorelease add this label to a pr to trigger a beta release label Nov 13, 2022
@github-actions github-actions bot removed the 🚀 autorelease add this label to a pr to trigger a beta release label Nov 13, 2022
@juliusmarminge
Copy link
Member Author

I don't like the delay but not sure if there's a way to get rid of it?
CleanShot 2022-11-13 at 12 16 06

@juliusmarminge juliusmarminge added the 🚀 autorelease add this label to a pr to trigger a beta release label Nov 13, 2022
@github-actions github-actions bot removed the 🚀 autorelease add this label to a pr to trigger a beta release label Nov 13, 2022
@juliusmarminge juliusmarminge added the 🚀 autorelease add this label to a pr to trigger a beta release label Nov 13, 2022
@github-actions github-actions bot removed the 🚀 autorelease add this label to a pr to trigger a beta release label Nov 13, 2022
@juliusmarminge juliusmarminge added the 🚀 autorelease add this label to a pr to trigger a beta release label Nov 13, 2022
@github-actions github-actions bot removed the 🚀 autorelease add this label to a pr to trigger a beta release label Nov 13, 2022
@juliusmarminge
Copy link
Member Author

juliusmarminge commented Nov 13, 2022 •
edited
Loading

is awaiting better ux?

I think it is

@juliusmarminge juliusmarminge added the 🚀 autorelease add this label to a pr to trigger a beta release label Nov 13, 2022
@github-actions github-actions bot removed the 🚀 autorelease add this label to a pr to trigger a beta release label Nov 13, 2022
@juliusmarminge juliusmarminge added the 🚀 autorelease add this label to a pr to trigger a beta release label Nov 13, 2022
@github-actions github-actions bot removed the 🚀 autorelease add this label to a pr to trigger a beta release label Nov 13, 2022
@juliusmarminge juliusmarminge added the 🚀 autorelease add this label to a pr to trigger a beta release label Nov 13, 2022
@github-actions github-actions bot removed the 🚀 autorelease add this label to a pr to trigger a beta release label Nov 13, 2022
@c-ehrlich
Copy link
Member

Tested the prerelease version and it works for beta. Couldn't figure out how to test it for "real" versions but feel free to resolve and merge if you're sure it works for those :)

Also currently it will bring up the message if the user somehow managed to have a newer version than what's on npm, but I think this is actually a good thing.

@juliusmarminge
Copy link
Member Author

juliusmarminge commented Nov 13, 2022 •
edited
Loading

Tested the prerelease version and it works for beta. Couldn't figure out how to test it for "real" versions but feel free to resolve and merge if you're sure it works for those :)

I tested it by downgrading in my package.json locally.

Also currently it will bring up the message if the user somehow managed to have a newer version than what's on npm, but I think this is actually a good thing.

The only way that will happen is if they modify the version in the package.json so I think that's an edge case I'm willing pass on.

nexxeln
nexxeln approved these changes Nov 14, 2022
View reviewed changes
Copy link
Member

@nexxeln nexxeln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship i guess

@juliusmarminge juliusmarminge merged commit 57cb2b5 into next Nov 14, 2022
@juliusmarminge juliusmarminge deleted the version-warning branch November 14, 2022 07:09
@github-actions github-actions bot mentioned this pull request Nov 14, 2022
Merged
korawit-dvtx pushed a commit to korawit-dvtx/create-devviantex-nextjs-app-deprecated that referenced this pull request Jun 9, 2024
@juliusmarminge
feat: render warning when using a tagged or outdated version (t3-oss#727
9d2cdca 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c-ehrlich c-ehrlich c-ehrlich left review comments

@nexxeln nexxeln nexxeln approved these changes

@t3dotgg t3dotgg Awaiting requested review from t3dotgg

Assignees
No one assigned
Labels
📌 area: cli Relates to the CLI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@juliusmarminge @c-ehrlich @nexxeln