fix(document): serialize @cache directives #1058
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
type: docs
mogery
added a commit
to mogery/tailcall
that referenced
this pull request
Jan 28, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1058 +/- ##
==========================================
- Coverage 88.39% 88.38% -0.01%
==========================================
Files 99 99
Lines 10721 10712 -9
==========================================
- Hits 9477 9468 -9
Misses 1244 1244 ☔ View full report in Codecov by Sentry. |
mogery
changed the title
|
This is all ready now. Should be a quick merge. |
meskill
reviewed
Jan 29, 2024
Co-authored-by: Kiryl Mialeshka <[email protected]>
the previous behaviour was to apply type-level cache directives to fields at import time. this means that identity checks fail when type-level cache directives are used. this commit moves the type-to-field propagation logic to blueprint logic instead of config logic.
|
Pushed a new commit that fixes the identity fail of type-level cache directives, and adds a test for it. Should be good to go 👍🏻 |
meskill
approved these changes
Jan 29, 2024
|
Great work, thanks for the fix! |
mogery
added a commit
to mogery/tailcall
that referenced
this pull request
Jan 30, 2024
mogery
added a commit
to mogery/tailcall
that referenced
this pull request
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
@cachedirectives are not serialized when callingconfig.to_sdl(). This PR adds logic tointo_document.rsto fix this.Build & Testing:
cargo testsuccessfully../lint.sh --mode=fixto fix all linting issues raised by./lint.sh --mode=check.Checklist:
<type>(<optional scope>): <title>