Fix missing space around - when using % regression
#18289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobinMalfait
force-pushed
the
fix/issue-18288
branch
from
639c3c5 to
a64a3b2
Compare
thecrypticace
approved these changes
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a regression we shipped in v4.1.9, when using arbitrary values and injecting spaces around operator.
When you use
w-[calc(100%-var(--foo))], you expect that this generates valid CSS:But due to a regression, we generated:
Which is invalid CSS.
This is because the algorithm we used to know when we had to inject a space around the
-didn't take the%sign into account.We also didn't handle uppercase units like
123PXproperly. This PR fixes both issues.Test plan
%123PXFixes: #18288