Skip to content

docs(features): update upload.mdx #1924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 16, 2024
Merged

Conversation

dreyfus92
Copy link
Member

@dreyfus92 dreyfus92 commented Mar 5, 2024

What kind of changes does this PR include?

  • New or updated content

Description

Copy link

netlify bot commented Mar 5, 2024

Deploy Preview for tauri-docs-starlight ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 6753978
🔍 Latest deploy log https://app.netlify.com/sites/tauri-docs-starlight/deploys/65f5ca9b904ddf000831c1ac
😎 Deploy Preview https://deploy-preview-1924--tauri-docs-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@FabianLars
Copy link
Member

ah damn, that's my bad. @amrbashir We still want to merge it into the http plugin right?

@amrbashir
Copy link
Member

I think it is fine to keep as is (or removed) since a combination of http + fs plugins can achieve the same thing?

I am a bit hesitated to merge into http plugin because we will need to handle scope for the filesystem as well and also upload plugin have a bit more dependencies that may not concern most users using http plugin.

@FabianLars
Copy link
Member

a combination of http + fs plugins can achieve the same thing?

That'd be much slower because the data would have to go through the ipc. The v2 ipc may be faster, but not that much faster :/

also upload plugin have a bit more dependencies that may not concern most users using http plugin.

imo feature flags would be fine for that 🤷

because we will need to handle scope for the filesystem as well

Hmm, that's indeed annoying and a good reason...

@amrbashir
Copy link
Member

amrbashir commented Mar 6, 2024

I guess better to be kept as a standalone plugin

@FabianLars
Copy link
Member

should we rename it to http-extra? 😂 (not actually meant as a joke, i don't like the upload name when it can download too)

@amrbashir
Copy link
Member

sure, whatever sounds right with you

@dreyfus92
Copy link
Member Author

@FabianLars, so should I close this?

@FabianLars
Copy link
Member

No, seems like we keep the plugin. If we indeed rename it then we can just change the docs 🤷

@dreyfus92 dreyfus92 marked this pull request as ready for review March 8, 2024 19:29
@dreyfus92 dreyfus92 requested a review from a team as a code owner March 8, 2024 19:29
Copy link
Contributor

@vasfvitor vasfvitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's ok, have you used the plugin yourself to make sure it works as intended and this code is reproducible?

@dreyfus92 dreyfus92 merged commit e16eb38 into tauri-apps:next Mar 16, 2024
@dreyfus92 dreyfus92 deleted the plugin-upload branch April 30, 2024 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Create Upload guide
4 participants