-
Notifications
You must be signed in to change notification settings - Fork 755
docs(features): update upload.mdx
#1924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for tauri-docs-starlight ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
ah damn, that's my bad. @amrbashir We still want to merge it into the http plugin right? |
I think it is fine to keep as is (or removed) since a combination of I am a bit hesitated to merge into http plugin because we will need to handle scope for the filesystem as well and also upload plugin have a bit more dependencies that may not concern most users using http plugin. |
That'd be much slower because the data would have to go through the ipc. The v2 ipc may be faster, but not that much faster :/
imo feature flags would be fine for that 🤷
Hmm, that's indeed annoying and a good reason... |
I guess better to be kept as a standalone plugin |
should we rename it to http-extra? 😂 (not actually meant as a joke, i don't like the upload name when it can download too) |
sure, whatever sounds right with you |
@FabianLars, so should I close this? |
No, seems like we keep the plugin. If we indeed rename it then we can just change the docs 🤷 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's ok, have you used the plugin yourself to make sure it works as intended and this code is reproducible?
Co-authored-by: Vitor Ayres <[email protected]>
What kind of changes does this PR include?
Description
Updates
/features/upload
page