generated from tc39/template-for-proposals
-
Notifications
You must be signed in to change notification settings - Fork 3
Stay reasonably neutral in problem statement #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dcodeIO
wants to merge
38
commits into
tc39:main
Choose a base branch
from
dcodeIO:patch-1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
147a84f
Stay reasonably neutral in problem statement
dcodeIO c32cfa5
Update README.md
dcodeIO 8acfac3
focus on neutrality with slightly more background
dcodeIO 4832d5d
slightly better
dcodeIO 9a44455
more balance
dcodeIO 7cd3d8d
clarify
dcodeIO 6bb703d
condense
dcodeIO 2890191
less is more
dcodeIO c7deea1
ESM complications
dcodeIO 7cdb1b6
context
dcodeIO daa77a4
leave doors open
dcodeIO 2aeec56
neutral
dcodeIO d376e18
clarify
dcodeIO e13596b
JSON precedent
dcodeIO d5bee50
bridge
dcodeIO fa5f7eb
better not
dcodeIO dcf8b79
neutralize
dcodeIO 573b7ec
concrete
dcodeIO 81ca23a
mention stringref
dcodeIO b73a4f6
but mention at the side for WTF-8 context
dcodeIO 01a14dc
fix copy pasta
dcodeIO 4623be6
too much nesting
dcodeIO 1256d4d
move details to FAQ
dcodeIO eaf162b
clarify
dcodeIO acb3a51
minus redundancy
dcodeIO 44c4930
Update README.md
dcodeIO 85bdd14
less verbose
dcodeIO ad12765
mention strategy
dcodeIO afa8147
actually redundant
dcodeIO be47eba
neutral
dcodeIO 321481f
references
dcodeIO af1e54e
clarify
dcodeIO e2a67aa
redundant links should be fine
dcodeIO 0fa2989
depends
dcodeIO 06ecb99
reuse exact wording
dcodeIO a013bb1
superfluous
dcodeIO 1f473a8
condense
dcodeIO c7ebcc2
wording
dcodeIO File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR seems fine to me now, if this entire superfluous section is removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are several direct connections to this proposal in this section of the FAQ (that I moved there from the problem statement to do ya'll a favor btw). In addition to explaining why the CM is probably the most notable precedent for this proposal, why timings overlap, why this is special, why performance is important, etc., the paragraph also aids future discussion. Today, this proposal uses the CM as an argument, and it is likely that tomorrow the CM will use this proposal as an argument to bolster its choices because "but you can check". This is highly relevant context that, if withheld for editorial reasons, will not be obvious and likely lead to worse results overall than if it was provided. Please let's be responsible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a JS developer, I should not need to understand or read anything about wasm beyond "wasm requires well-formed strings". None of the info about the component model is relevant to me. A TC39 proposal is not an appropriate place to create leverage for an argument within wasm.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not intended as leverage, really. If you can point me to sentences that feel like it to you, please tell me, and I'll do my best to phrase as objectively as I humanly can. Hardly anyone knows about the nitty gritty details in play here (this proposal helps to some extent), even less people know how all this is connected, but exactly this knowledge is important, now more than ever with the CM doing things differently than the platform has done it before. As a JS developer, you should care because you have dependencies, and these dependencies have dependencies, you upgrade them, you bundle them. This string stuff is subtle, but also fundamental, and errors are delayed, almost impossible to spot. With the CM, JS developers need a bunch of highly specialized knowledge now that they didn't necessarily need to care about before. I do think that we are acting responsibly when we try our best to let them know about the what and why, so they can address it, either in code or in the spec. Please give me a realistic chance to improve this FAQ section. I think it's important that people are aware. That there is discourse about this, knowledge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the place that awareness should be spread is a wasm arena, not a JS one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, this is about helping JS devs. To help TC39. ECMAScript. I am out of options in Wasm, nobody cares there :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's exactly the point - if wasm's decisions here aren't going to change, why is this extra context useful to JS devs? All they need to know is what a well-formed string is, how to check for it, and how to sanitize one if needed - which this proposal already provides for.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that the CM is in phase 1, it's too early to know for sure whether Wasm's decisions are going to last. And as I said in my prior comment, JS devs, in particular those intending to consume Wasm modules, even more so those with an interest to use JS and Wasm in tandem (which is a fantastic use case btw and one of Wasm's stated goals), should care:
If they are kept in the dark, this will just remain the self-fulfilling prophecy it already is: Wasm does its thing, while all attempts to inform or include JS devs are stonewalled. Greetings to the same Wasm folks up- and downvoting here btw. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If wasm makes decisions that make JS interop harder in practice, that hurts wasm devs, not JS devs, because that will just inhibit use of wasm. I don't see what JS devs can do about it - nor do I think that the entry to the wasm funnel will be on this particular TC39 proposal.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That doesn't sound like a good outcome, rather like an argument to better have an FAQ entry so nobody is hurt unknowingly. I think there's a lot JS devs with an interest for Wasm can do btw. (I'm one of them, and look at me), just not if relevant context is withheld from them. And for sure this proposal is the entry point: Want to know what the problem is? Direct here. Ran into an issue? Direct here. Component Model? Soon directs here. In a sense, JS and Wasm meet exactly here, where the problem is addressed with manual checks.