Editorial: Close more old non-normative issues #2815
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2815 +/- ##
==========================================
+ Coverage 96.49% 96.56% +0.06%
==========================================
Files 23 23
Lines 12304 12386 +82
Branches 2272 2298 +26
==========================================
+ Hits 11873 11960 +87
+ Misses 372 364 -8
- Partials 59 62 +3 ☔ View full report in Codecov by Sentry. |
Ms2ger
approved these changes
Apr 3, 2024
The Set specification type's definition says that it is for use in the memory model. Rather than open the can of worms to extend the definition, just use a List and remove duplicates from it before returning it. Closes: #2531
The time zone does not affect the `daysInMonth` value even if a 24-hour UTC offset shift causes a skipped day, so this claim is false. Closes: #2495
…ties This matches the other type assertions in es-abstract.
Previously we did not care very much about fidelity for the replacement Intl.DateTimeFormat object, since the point of this code is to run the Temporal tests. Occasionally people want to run the Intl.DateTimeFormat tests and are surprised that it doesn't work. Things we have to do to get the Intl.DateTimeFormat tests to pass: - Change ASCIILowercase not to use a RegExp, so that it doesn't clobber legacy RegExp variables like RegExp.$_. (Probably this means that for a 100% conformant polyfill, you can't use any RegExp anywhere. I'm not bothering with that.) - Change DateTimeFormat to be a class, DateTimeFormatImpl. Methods defined in a class body don't have a 'prototype' property and can't be called as constructors, whereas regular functions do. (However, we still need a regular function to construct DateTimeFormat, because it needs to be able to be invoked without 'new'.) - Use CreateSlots/GetSlot/SetSlot like the other Temporal objects, instead of symbol-valued properties. The symbol-valued properties were observably present for user code. - In the constructor, observably read all the options from the options bag in the expected order, and copy them to a null-prototype object with which we do subsequent operations unobservably. - Implement the behaviour of format() already having bound the correct this-object. - Previously we only half-implemented the normative optional behaviour of being able to 'bless' a plain object into becoming a DateTimeFormat object. Instead, just don't implement it at all. (A real production polyfill should probably check if the existing Intl.DateTimeFormat has that behaviour, and match that.) Closes: #2471
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2471, #2495, #2531