Update to latest test262, minor reference code improvements #3104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ptomato
commented
Apr 21, 2025
ptomato
commented
- Update to latest test262
- A few minor improvements
- Fix bug in calendar code (not corresponding to any spec steps)
One implementation (in the Persian calendar) has the wrong name so never got invoked. Another implementation (Chinese/Dangi calendars) interpreted the passed-in argument incorrectly. But it would eventually come up with the right answer, after searching 20 years.
While going over this code I was very confused by this line. I've added a comment to explain it.
This line would accidentally convert the BigInt epoch nanoseconds to Numbers, potentially losing microseconds or nanoseconds, before subtracting. It did not affect any results, because no offset transitions occur on microsecond or nanosecond boundaries.
Instead of doing a multiplication here, we can just check if the remainder is zero. This matters a bit more for TimeDuration and RoundNumberToIncrementAsIfPositive, because we avoid a BigInt multiplication.
Skip calculating isEven if we short-circuit ApplyUnsignedRoundingMode in RoundNumberToIncrementAsIfPositive.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3104 +/- ##
==========================================
+ Coverage 96.71% 96.75% +0.03%
==========================================
Files 21 21
Lines 9951 9950 -1
Branches 1807 1812 +5
==========================================
+ Hits 9624 9627 +3
+ Misses 281 277 -4
Partials 46 46 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Ms2ger
approved these changes
May 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.