-
Notifications
You must be signed in to change notification settings - Fork 485
merge immutable-arraybuffer tests #4445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@phoddie This is pretty noisy right now; please fix the lint issues:
- Add necessary front matter fields
- Update features.txt
- Fix the copyrights to a single year rather than a range
- etc.
Sure, will do. FWIW – "Fix the copyrights to a single year rather than a range" feels artificial. |
It's not; it ensures that the range doesn't need to be updated every year. |
Rebasing on main will also get the annotation improvements from #4449. |
??? The range only needs to be updated in years when the tests are modified, not when the calendar advances. Anyway. I will change the tests to conform with this peculiar requirement. |
The linter is now happy and I've attempted to resolve all comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am a champion of the proposal and will not formally approve this PR would appreciate attention from other maintainers, but I have reviewed it and confirmed consistency with the proposal. Followups are expected to cover error handling and ArrayBuffer.prototype.sliceToImmutable, but this LGTM.
var immutable = Object.getOwnPropertyDescriptor( | ||
ArrayBuffer.prototype, "immutable" | ||
); | ||
|
||
var getter = immutable.get; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit:
var immutable = Object.getOwnPropertyDescriptor( | |
ArrayBuffer.prototype, "immutable" | |
); | |
var getter = immutable.get; | |
var getter = Object.getOwnPropertyDescriptor( | |
ArrayBuffer.prototype, "immutable" | |
).get; | |
var immutable = Object.getOwnPropertyDescriptor( | ||
ArrayBuffer.prototype, "immutable" | ||
); | ||
|
||
var getter = immutable.get; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit:
var immutable = Object.getOwnPropertyDescriptor( | |
ArrayBuffer.prototype, "immutable" | |
); | |
var getter = immutable.get; | |
var getter = Object.getOwnPropertyDescriptor( | |
ArrayBuffer.prototype, "immutable" | |
).get; | |
Suite of test262 tests for the Immutable ArrayBuffer proposal.